From: David Vrabel <david.vrabel@citrix.com>
To: Yijing Wang <wangyijing@huawei.com>, Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 2/3] x86/xen: Revert "PCI: Add x86_msi.msi_mask_irq() and msix_mask_irq()"
Date: Mon, 27 Oct 2014 11:10:32 +0000 [thread overview]
Message-ID: <544E2828.9060901@citrix.com> (raw)
In-Reply-To: <1414377878-23497-3-git-send-email-wangyijing@huawei.com>
On 27/10/14 02:44, Yijing Wang wrote:
> Commit 0e4ccb1505a9 ("PCI: Add x86_msi.msi_mask_irq() and msix_mask_irq()")
> introduced two __weak arch functions arch_msix_mask_irq() and
> arch_msi_mask_irq() to work around a bug when running xen in x86.
> These two functions made msi code more complex. We have introduced
> a global flag to ignore MSI mask to fix the issue in previous patch,
> so we can revert the commit safely. This patch is also preparation
> to use MSI chip framework instead of weak arch MSI functions in all
> platforms. Because s390 MSI also use default_msi_mask_irq() functions
> introduced by commit 0e4ccb1505a9. We keep default_msi_mask_irq()
> and default_msix_mask_irq() temporarily. They will be removed in later
> patch.
Acked-by: David Vrabel <david.vrabel@citrix.com>
David
next prev parent reply other threads:[~2014-10-27 11:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 2:44 [PATCH 0/3] xen MSI code clean up Yijing Wang
2014-10-27 2:44 ` [PATCH 1/3] x86/xen: Introduce a global flag to fix the MSI mask bug Yijing Wang
2014-10-27 2:44 ` Yijing Wang
2014-10-27 11:09 ` [Xen-devel] " David Vrabel
2014-10-27 19:45 ` Konrad Rzeszutek Wilk
2014-10-28 16:44 ` David Vrabel
2014-10-28 16:57 ` Konrad Rzeszutek Wilk
2014-10-28 16:57 ` Konrad Rzeszutek Wilk
2014-10-28 16:44 ` David Vrabel
2014-10-27 19:45 ` Konrad Rzeszutek Wilk
2014-10-27 11:09 ` David Vrabel
2014-11-11 0:04 ` Bjorn Helgaas
2014-11-11 1:49 ` Yijing Wang
2014-11-11 1:49 ` Yijing Wang
2014-11-11 15:45 ` Konrad Rzeszutek Wilk
2014-11-11 20:24 ` Bjorn Helgaas
2014-11-11 20:24 ` Bjorn Helgaas
2014-11-11 22:04 ` Konrad Rzeszutek Wilk
2014-11-11 22:04 ` Konrad Rzeszutek Wilk
2014-11-11 15:45 ` Konrad Rzeszutek Wilk
2014-11-11 0:04 ` Bjorn Helgaas
2014-10-27 2:44 ` [PATCH 2/3] x86/xen: Revert "PCI: Add x86_msi.msi_mask_irq() and msix_mask_irq()" Yijing Wang
2014-10-27 2:44 ` Yijing Wang
2014-10-27 11:10 ` David Vrabel
2014-10-27 11:10 ` David Vrabel [this message]
2014-10-27 2:44 ` [PATCH 3/3] s390/MSI: Use __msi_mask_irq() instead of default_msi_mask_irq() Yijing Wang
2014-10-27 2:44 ` Yijing Wang
2014-11-11 21:23 ` [PATCH 0/3] xen MSI code clean up Bjorn Helgaas
2014-11-11 21:23 ` Bjorn Helgaas
2014-11-12 9:24 ` Sebastian Ott
2014-11-12 9:24 ` Sebastian Ott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E2828.9060901@citrix.com \
--to=david.vrabel@citrix.com \
--cc=bhelgaas@google.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-pci@vger.kernel.org \
--cc=wangyijing@huawei.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.