From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Ian Campbell <Ian.Campbell@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: xl/SR-IOV: disposition of VFs when PF disappears?
Date: Mon, 27 Oct 2014 13:03:19 +0000 [thread overview]
Message-ID: <544E4297.1070209@citrix.com> (raw)
In-Reply-To: <544E4A4E020000780004267D@mail.emea.novell.com>
On 27/10/14 12:36, Jan Beulich wrote:
> All,
>
> Intel reports that the sequence
>
> - xl pci-assignable-add <VF>
> - briefly run guest using that device [not sure whether that's really a
> necessary step]
> - xl pci-assignable-add <PF of VF>
>
> results in both VF and PF being listed as assignable (the fact that as a
> result the PF handed to a guest doesn't work is secondary here, as I
> think this is a driver issue). Is that really how it should be? Shouldn't
> instead all VFs get removed when the PF device (e.g. due to the
> PF driver getting unloaded, which is a necessary part of making it
> assignable) goes away? Or is it required for the admin to manually
> remove the assignable VFs prior to making the PF go away?
Which type of devices are these?
>From my recollection using igb and ixgbe with Netscalar, the VFs are
created after the PF driver has bound and started up.
Moving the binding from the real PF driver to pciback should remove the
VFs, although I would not be surprised if this has been overlooked, or
is expected to work but currently buggy.
As a logical consequence of the above, a PF with VFs must strictly not
be assignable, for safety reasons.
There are security considerations involved with passing a PF to a
domain, as that domU can still cause VFs to appear in dom0. A PF should
either stay in dom0, be given to a trusted device driver domain.
~Andrew
next prev parent reply other threads:[~2014-10-27 13:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 12:36 xl/SR-IOV: disposition of VFs when PF disappears? Jan Beulich
2014-10-27 12:57 ` Ian Campbell
2014-10-27 13:07 ` Jan Beulich
2014-10-27 13:35 ` Konrad Rzeszutek Wilk
2014-10-27 17:53 ` Anirban Chakraborty
2014-10-27 17:57 ` Stefano Stabellini
2014-10-27 18:07 ` Konrad Rzeszutek Wilk
2014-10-27 19:53 ` Anirban Chakraborty
2014-10-28 10:25 ` Jan Beulich
2014-10-28 14:00 ` Konrad Rzeszutek Wilk
2014-10-28 15:18 ` Jan Beulich
2014-10-28 16:25 ` Jan Beulich
2014-10-28 16:30 ` Jan Beulich
2014-10-28 16:56 ` Konrad Rzeszutek Wilk
2014-10-29 7:45 ` Jan Beulich
2014-10-27 13:03 ` Andrew Cooper [this message]
2014-10-27 13:12 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E4297.1070209@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=Ian.Campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.