From: Eric Sandeen <sandeen@sandeen.net>
To: Christoph Hellwig <hch@infradead.org>
Cc: Eric Sandeen <sandeen@redhat.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: enable sparse checking
Date: Mon, 27 Oct 2014 08:25:21 -0500 [thread overview]
Message-ID: <544E47C1.5070906@sandeen.net> (raw)
In-Reply-To: <20141027094800.GB31604@infradead.org>
On 10/27/14 4:48 AM, Christoph Hellwig wrote:
> On Fri, Oct 24, 2014 at 10:48:55AM -0500, Eric Sandeen wrote:
>> On 10/24/14 10:40 AM, Christoph Hellwig wrote:
>>> strong opinion. It's not like your patch prevents me from using CC=cgcc
>>
>> To get endian checking with your method, you'd need to edit
>> the Makefile to add the -D define, right?
>
> That's a kernel special, I just did a test run using CC=cgcc and I get
> endianess warnings:
>
> rdwr.c:190:21: warning: incorrect type in assignment (different base types)
> rdwr.c:190:21: expected restricted __le32 [usertype] h_crc
> rdwr.c:190:21: got restricted __be32 [usertype] <noident>
Oh, without an extra define? Hrm. Ok I guess I need to read
up on what enables it.
I did send a couple patches to fix some of these. Sorry, didn't
do it in a series:
[PATCH] xfsprogs: fix endian mishap in xfs_dialloc_ag()
[PATCH] xfsprogs: fix harmless sparse endian nit
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-10-27 13:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 23:29 [PATCH] xfsprogs: enable sparse checking Eric Sandeen
2014-10-24 6:17 ` Christoph Hellwig
2014-10-24 13:53 ` Eric Sandeen
2014-10-24 15:40 ` Christoph Hellwig
2014-10-24 15:48 ` Eric Sandeen
2014-10-27 9:48 ` Christoph Hellwig
2014-10-27 13:25 ` Eric Sandeen [this message]
2014-10-27 18:50 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E47C1.5070906@sandeen.net \
--to=sandeen@sandeen.net \
--cc=hch@infradead.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.