From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] KVM: trivial fix comment regarding __kvm_set_memory_region Date: Mon, 27 Oct 2014 16:51:01 +0100 Message-ID: <544E69E5.7040700@redhat.com> References: <1414423376-64491-1-git-send-email-dingel@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Gleb Natapov , kvm@vger.kernel.org, linux-kernel@vger.kernel.org To: Dominik Dingel Return-path: In-Reply-To: <1414423376-64491-1-git-send-email-dingel@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 10/27/2014 04:22 PM, Dominik Dingel wrote: > commit 72dc67a69690 ("KVM: remove the usage of the mmap_sem for the protection of the memory slots.") > changed the lock which will be taken. This should be reflected in the function > commentary. Whoa, February 2008. :) Thanks, applying this patch. Paolo > Signed-off-by: Dominik Dingel > --- > virt/kvm/kvm_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c > index d82ec25..8b13607 100644 > --- a/virt/kvm/kvm_main.c > +++ b/virt/kvm/kvm_main.c > @@ -738,7 +738,7 @@ static struct kvm_memslots *install_new_memslots(struct kvm *kvm, > * > * Discontiguous memory is allowed, mostly for framebuffers. > * > - * Must be called holding mmap_sem for write. > + * Must be called holding kvm->slots_lock for write. > */ > int __kvm_set_memory_region(struct kvm *kvm, > struct kvm_userspace_memory_region *mem) >