From: Eric Sandeen <sandeen@redhat.com>
To: Brian Foster <bfoster@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs_io: add sync and syncfs commands
Date: Mon, 27 Oct 2014 10:56:41 -0500 [thread overview]
Message-ID: <544E6B39.9040309@redhat.com> (raw)
In-Reply-To: <20141027114327.GD39598@bfoster.bfoster>
On 10/27/14 6:43 AM, Brian Foster wrote:
> On Fri, Oct 24, 2014 at 01:06:09PM -0500, Eric Sandeen wrote:
...
>> +void
>> +sync_init(void)
>> +{
>> + sync_cmd.name = "sync";
>> + sync_cmd.cfunc = sync_f;
>> + sync_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
>
> Not a big deal given that we have sync(1), but CMD_NOFILE_OK..?
>
> The rest looks good to me.
>
> Brian
Ah, good eye, thanks. Will send V2.
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-10-27 15:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 18:06 [PATCH] xfs_io: add sync and syncfs commands Eric Sandeen
2014-10-27 11:43 ` Brian Foster
2014-10-27 15:56 ` Eric Sandeen [this message]
2014-10-27 18:55 ` [PATCH V2] " Eric Sandeen
2014-10-27 21:50 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E6B39.9040309@redhat.com \
--to=sandeen@redhat.com \
--cc=bfoster@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.