From: "H. Peter Anvin" <hpa@zytor.com>
To: Eric Paris <eparis@redhat.com>, Richard Guy Briggs <rgb@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, przanoni@gmail.com,
mingo@kernel.org, hpa@linux.intel.com,
linux-tip-commits@vger.kernel.org, linux-audit@redhat.com
Subject: Re: [PATCH] i386/audit: stop scribbling on the stack frame
Date: Mon, 27 Oct 2014 10:02:05 -0700 [thread overview]
Message-ID: <544E7A8D.1030909@zytor.com> (raw)
In-Reply-To: <1414418157.24347.1.camel@redhat.com>
On 10/27/2014 06:55 AM, Eric Paris wrote:
> My patch was already committed to the -tip urgent branch. I believe any
> optimization should be based on that branch, Richard. If you are trying
> to wrangle every bit of speed out of this, should you
>
> push %esi;
> push %edi;
> CFI_ADJUST_CFA_OFFSET 8
> call __audit_syscall_entry
> pop;
> pop;
> CFI_ADJUST_CFA_OFFSET -8
>
> Instead of using the pushl_cfi and popl_cfi macros?
>
> I wrote my patch to be obviously correct, but agree there are certainly
> some speedups possible.
>
Uh... not only is that plain wrong (the CFI should be adjusted after
each instruction that changes the stack pointer), but what the heck is
wrong with using the macros?
-hpa
next prev parent reply other threads:[~2014-10-27 17:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 4:04 [PATCH] i386/audit: stop scribbling on the stack frame Eric Paris
2014-10-23 18:39 ` Andy Lutomirski
2014-10-23 19:13 ` H. Peter Anvin
2014-10-23 19:15 ` Eric Paris
2014-10-23 19:20 ` Andy Lutomirski
2014-10-23 19:30 ` Eric Paris
2014-10-23 19:30 ` Eric Paris
2014-10-23 19:38 ` Eric Paris
2014-10-24 20:19 ` H. Peter Anvin
2014-10-25 0:00 ` Andy Lutomirski
2014-10-27 2:06 ` Richard Guy Briggs
2014-10-23 20:30 ` Andy Lutomirski
2014-10-24 2:55 ` H. Peter Anvin
2014-10-27 2:01 ` Richard Guy Briggs
2014-10-24 20:31 ` [tip:x86/urgent] " tip-bot for Eric Paris
2014-10-25 8:36 ` Thomas Gleixner
2014-10-27 2:34 ` [PATCH] " Richard Guy Briggs
2014-10-27 13:55 ` Eric Paris
2014-10-27 17:02 ` H. Peter Anvin [this message]
2014-10-27 17:29 ` Eric Paris
2014-10-28 6:30 ` Ingo Molnar
2014-10-27 17:38 ` Richard Guy Briggs
2014-10-27 21:18 ` Thomas Gleixner
2014-10-27 21:22 ` Richard Guy Briggs
2014-10-27 20:52 ` Thomas Gleixner
2014-10-27 21:13 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E7A8D.1030909@zytor.com \
--to=hpa@zytor.com \
--cc=eparis@redhat.com \
--cc=hpa@linux.intel.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=przanoni@gmail.com \
--cc=rgb@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.