From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for non-existing backing file
Date: Mon, 27 Oct 2014 11:14:23 -0600 [thread overview]
Message-ID: <544E7D6F.9090802@redhat.com> (raw)
In-Reply-To: <1414413009-9008-3-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On 10/27/2014 06:30 AM, Max Reitz wrote:
> Test the error message when a COW file is about to be created which is
> supposed to inherit the size of its backing file, while the backing file
> given does not actually exist.
>
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> +
> +$QEMU_IMG create -f $IMGFMT -b "$TEST_IMG.inexistent" "$TEST_IMG" 2>&1 \
> + | _filter_testdir | _filter_imgfmt
inexistent it a nonexistent word :) But it correctly tests the problem.
> +++ b/tests/qemu-iotests/111.out
> @@ -0,0 +1,3 @@
> +QA output created by 111
> +qemu-img: TEST_DIR/t.IMGFMT: Could not open 'TEST_DIR/t.IMGFMT.inexistent': No such file or directory
I'm okay whether you leave the test as-is, or s/in/non/ in two places.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-27 17:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 12:30 [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create() Max Reitz
2014-10-27 12:30 ` [Qemu-devel] [PATCH 1/2] " Max Reitz
2014-10-27 12:30 ` [Qemu-devel] [PATCH 2/2] iotests: Add test for non-existing backing file Max Reitz
2014-10-27 17:14 ` Eric Blake [this message]
2014-10-28 8:29 ` Max Reitz
2014-10-27 12:46 ` [Qemu-devel] [PATCH 0/2] block: Propagate error in bdrv_img_create() Peter Lieven
2014-10-28 12:27 ` Kevin Wolf
2014-10-29 10:42 ` Stefan Hajnoczi
2014-11-03 12:33 ` Max Reitz
2014-11-03 13:38 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544E7D6F.9090802@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.