From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xioyl-00025q-Ti for qemu-devel@nongnu.org; Mon, 27 Oct 2014 14:25:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xioyf-0004ZQ-5p for qemu-devel@nongnu.org; Mon, 27 Oct 2014 14:25:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53346 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xioye-0004ZG-RQ for qemu-devel@nongnu.org; Mon, 27 Oct 2014 14:25:13 -0400 Message-ID: <544E8E06.6080804@suse.de> Date: Mon, 27 Oct 2014 19:25:10 +0100 From: =?windows-1252?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <20141020102559.GA29278@stefanha-thinkpad.redhat.com> <20141022100318.GC8798@stefanha-thinkpad.redhat.com> In-Reply-To: <20141022100318.GC8798@stefanha-thinkpad.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="3IGvt3Khpq38Cb385i5ppkqWR9gvSv3qq" Subject: Re: [Qemu-devel] Patch checking bot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Fam Zheng , Peter Maydell , John Snow , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --3IGvt3Khpq38Cb385i5ppkqWR9gvSv3qq Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Hi, Am 22.10.2014 um 12:03 schrieb Stefan Hajnoczi: > On Mon, Oct 20, 2014 at 03:08:35PM +0100, Peter Maydell wrote: >> On 20 October 2014 11:25, Stefan Hajnoczi wrote:= >>> At KVM Forum 2014 we discussed a patch checking bot that automates pa= tch >>> format checking and smoke testing: >>> >>> 1. Did the patch submitter include Signed-off-by? >>> 2. Does checkpatch.pl pass? >>> 3. Does the patch apply to qemu.git/master? >>> 4. Does each patch compile? >>> 5. Does the series pass make check and qemu-iotests? >>> >>> Here are some thoughts on the patch checker: >>> >>> If a patch series passes successfully, no email is sent. If a patch >>> series fails, an email with the errors is sent as a reply to the patc= h >>> series email thread. The patch submitter can then respond in case th= ere >>> are false positive (e.g. from checkpatch.pl) - the bot doesn't care >>> about replies but it tells the human reviewers and maintainers what t= he >>> patch submitter intends to do. >> >> Probably also worth having a feature where the cover >> letter or patch can have a "patchchecker: no" line in >> it to tell the bot to ignore something, so people can >> avoid it sending lots of mail for patch series they >> know don't apply to mainline (eg ones which depend on >> a previous series). >=20 > The bot would send 1 email reply with a report of all errors. That > doesn't seem too noisy. Anthony had implemented that at some point and at times it spammed quite a lot. No real objection, just reminding. > That said, a header line to ignore the series is easy to implement so w= e > might as well. Anthony had simply detected [PATCH treename n/m] as not applying to master iirc, which was also useful to human inbox readers. Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg --3IGvt3Khpq38Cb385i5ppkqWR9gvSv3qq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJUTo4GAAoJEPou0S0+fgE/OpgQAK/i+fbusAy1xCQiSpsFjWci RPsZzMY1jlnpZZViY4sTTDc1ZUm5sHiDVNCrrOY+Rjk3fCHKdFyP/mHXfnQoP/+0 JkL3XaGgkQ9J+aNr62pizLaEs6ocgvQ541ykut/BKLxGr1kwvIvv8QOSZlkv6ni4 qP6JHYl9SlzzqJEr/eWdb/+3S6wbkg2BqYo2HkJC5pVfA+eN1RloMtw+LJbQvuxl QQIDh1yUgpBzwdr4QDt0MfgfA43X2nbMZaoZ8rXHyaECSTYgC9BNvuReKWtHtab1 jyalkHsw+KcZQMUAZLzXuWmoUV30UNl1K4lM55ZqBFh7rlsSnRMP9h7wjNAggDN6 H7jou6El5zyP18Yj8Whi+qyw3QIo9tOJUHX0XI4Hn9zswQFjs/Jwgu67JJ+u/4AJ E5SsvE3yWzd4YrWDegrTYMkB6QHI1+GS0Tj2+2mQcFKb4aRYM8GCXZq7AljxSTMr OFzrNtc2LsusgldOeXwKcyZxZBRFhcGJ5Z8xkdoUmP6FyZ0iLKS6+K+qtTTJhYio ehSVz6ZRziQ53eaHXZt6EhNtpfQIZuV2ZIbgkqnl4XWI90IcHCA8MfWBkrzHCkpx B2qQIPTatMFaZkFFMcwdG2f7UFowGtOaSR5gHKgEcBT7ZHAD2DczN2q1YBJ6GWKM wHMhNiTqEwNDlU0Un6eF =froH -----END PGP SIGNATURE----- --3IGvt3Khpq38Cb385i5ppkqWR9gvSv3qq--