From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Chen, Tiejun" Subject: Re: [v7][RFC][PATCH 01/13] introduce XENMEM_reserved_device_memory_map Date: Tue, 28 Oct 2014 10:22:42 +0800 Message-ID: <544EFDF2.5000303@intel.com> References: <1414136077-18599-1-git-send-email-tiejun.chen@intel.com> <1414136077-18599-2-git-send-email-tiejun.chen@intel.com> <544A7A150200007800041FAC@mail.emea.novell.com> <544DA9C5.90506@intel.com> <544E21AA0200007800042540@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <544E21AA0200007800042540@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: yang.z.zhang@intel.com, kevin.tian@intel.com, tim@xen.org, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 2014/10/27 17:42, Jan Beulich wrote: >>>> On 27.10.14 at 03:11, wrote: >> On 2014/10/24 22:11, Jan Beulich wrote: >>>>>> On 24.10.14 at 09:34, wrote: >>>> From: Jan Beulich >>>> >>>> This is a prerequisite for punching holes into HVM and PVH guests' P2M >>>> to allow passing through devices that are associated with (on VT-d) >>>> RMRRs. >>>> >>>> Signed-off-by: Jan Beulich >>>> Signed-off-by: Tiejun Chen >>> >>> I'm confused - you dropped Kevins ack and instead added you S-o-b >> >> I need to add this ACK. >> >>> despite you not having changed anything in the patch. >> >> The original you sent to me previously is needed to rebase on the >> latest. Please check xen/include/public/memory.h. >> >> The original: >> >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -573,7 +573,29 @@ struct vnuma_topology_info { >> typedef struct vnuma_topology_info vnuma_topology_info_t; >> DEFINE_XEN_GUEST_HANDLE(vnuma_topology_info_t); >> >> -/* Next available subop number is 27 */ >> >> Mine: >> >> --- a/xen/include/public/memory.h >> +++ b/xen/include/public/memory.h >> @@ -523,7 +523,29 @@ DEFINE_XEN_GUEST_HANDLE(xen_mem_sharing_ >> >> #endif /* defined(__XEN__) || defined(__XEN_TOOLS__) */ >> >> -/* Next available subop number is 26 */ >> >> Unless you're saying this kind of rebase shouldn't introduce my SOB. > > I indeed don't think rebasing counts as you actively doing any > changes. > Fine. I think this patch has a long history between us. Thanks Tiejun