From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ren Qiaowei Date: Tue, 28 Oct 2014 05:57:16 +0000 Subject: Re: [PATCH v9 10/12] x86, mpx: add prctl commands PR_MPX_ENABLE_MANAGEMENT, PR_MPX_DISABLE_MANAGEMEN Message-Id: <544F303C.10903@intel.com> List-Id: References: <1413088915-13428-1-git-send-email-qiaowei.ren@intel.com> <1413088915-13428-11-git-send-email-qiaowei.ren@intel.com> <9E0BE1322F2F2246BD820DA9FC397ADE0180ED65@shsmsx102.ccr.corp.intel.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thomas Gleixner Cc: "H. Peter Anvin" , Ingo Molnar , "Hansen, Dave" , "x86@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-mips@linux-mips.org" On 10/28/2014 04:38 AM, Thomas Gleixner wrote: > On Mon, 27 Oct 2014, Ren, Qiaowei wrote: >> On 2014-10-24, Thomas Gleixner wrote: >>> On Sun, 12 Oct 2014, Qiaowei Ren wrote: >>>> +int mpx_enable_management(struct task_struct *tsk) { >>>> + struct mm_struct *mm = tsk->mm; >>>> + void __user *bd_base = MPX_INVALID_BOUNDS_DIR; >>> >>> What's the point of initializing bd_base here. I had to look twice to >>> figure out that it gets overwritten by task_get_bounds_dir() >>> >> >> I just want to put task_get_bounds_dir() outside mm->mmap_sem holding. > > What you want is not interesting at all. What's interesting is what > you do and what you send for review. > I see. Thanks. - Qiaowei From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 28 Oct 2014 07:00:32 +0100 (CET) Received: from mga01.intel.com ([192.55.52.88]:62109 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010998AbaJ1GA26FgOV (ORCPT ); Tue, 28 Oct 2014 07:00:28 +0100 Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 27 Oct 2014 23:00:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,862,1389772800"; d="scan'208";a="407084852" Received: from rqw-ubuntu.sh.intel.com (HELO [10.239.37.69]) ([10.239.37.69]) by FMSMGA003.fm.intel.com with ESMTP; 27 Oct 2014 22:52:20 -0700 Message-ID: <544F303C.10903@intel.com> Date: Tue, 28 Oct 2014 13:57:16 +0800 From: Ren Qiaowei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Thomas Gleixner CC: "H. Peter Anvin" , Ingo Molnar , "Hansen, Dave" , "x86@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-mips@linux-mips.org" Subject: Re: [PATCH v9 10/12] x86, mpx: add prctl commands PR_MPX_ENABLE_MANAGEMENT, PR_MPX_DISABLE_MANAGEMENT References: <1413088915-13428-1-git-send-email-qiaowei.ren@intel.com> <1413088915-13428-11-git-send-email-qiaowei.ren@intel.com> <9E0BE1322F2F2246BD820DA9FC397ADE0180ED65@shsmsx102.ccr.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43612 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: qiaowei.ren@intel.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/28/2014 04:38 AM, Thomas Gleixner wrote: > On Mon, 27 Oct 2014, Ren, Qiaowei wrote: >> On 2014-10-24, Thomas Gleixner wrote: >>> On Sun, 12 Oct 2014, Qiaowei Ren wrote: >>>> +int mpx_enable_management(struct task_struct *tsk) { >>>> + struct mm_struct *mm = tsk->mm; >>>> + void __user *bd_base = MPX_INVALID_BOUNDS_DIR; >>> >>> What's the point of initializing bd_base here. I had to look twice to >>> figure out that it gets overwritten by task_get_bounds_dir() >>> >> >> I just want to put task_get_bounds_dir() outside mm->mmap_sem holding. > > What you want is not interesting at all. What's interesting is what > you do and what you send for review. > I see. Thanks. - Qiaowei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by kanga.kvack.org (Postfix) with ESMTP id 46FBC900021 for ; Tue, 28 Oct 2014 02:00:24 -0400 (EDT) Received: by mail-pa0-f43.google.com with SMTP id eu11so7039071pac.30 for ; Mon, 27 Oct 2014 23:00:24 -0700 (PDT) Received: from mga01.intel.com (mga01.intel.com. [192.55.52.88]) by mx.google.com with ESMTP id ru12si486999pac.48.2014.10.27.23.00.22 for ; Mon, 27 Oct 2014 23:00:23 -0700 (PDT) Message-ID: <544F303C.10903@intel.com> Date: Tue, 28 Oct 2014 13:57:16 +0800 From: Ren Qiaowei MIME-Version: 1.0 Subject: Re: [PATCH v9 10/12] x86, mpx: add prctl commands PR_MPX_ENABLE_MANAGEMENT, PR_MPX_DISABLE_MANAGEMENT References: <1413088915-13428-1-git-send-email-qiaowei.ren@intel.com> <1413088915-13428-11-git-send-email-qiaowei.ren@intel.com> <9E0BE1322F2F2246BD820DA9FC397ADE0180ED65@shsmsx102.ccr.corp.intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Thomas Gleixner Cc: "H. Peter Anvin" , Ingo Molnar , "Hansen, Dave" , "x86@kernel.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "linux-ia64@vger.kernel.org" , "linux-mips@linux-mips.org" On 10/28/2014 04:38 AM, Thomas Gleixner wrote: > On Mon, 27 Oct 2014, Ren, Qiaowei wrote: >> On 2014-10-24, Thomas Gleixner wrote: >>> On Sun, 12 Oct 2014, Qiaowei Ren wrote: >>>> +int mpx_enable_management(struct task_struct *tsk) { >>>> + struct mm_struct *mm = tsk->mm; >>>> + void __user *bd_base = MPX_INVALID_BOUNDS_DIR; >>> >>> What's the point of initializing bd_base here. I had to look twice to >>> figure out that it gets overwritten by task_get_bounds_dir() >>> >> >> I just want to put task_get_bounds_dir() outside mm->mmap_sem holding. > > What you want is not interesting at all. What's interesting is what > you do and what you send for review. > I see. Thanks. - Qiaowei -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org