From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] clang warning
Date: Tue, 28 Oct 2014 14:58:12 +0200 [thread overview]
Message-ID: <544F92E4.6030305@compulab.co.il> (raw)
In-Reply-To: <544ED917.8020305@myspectrum.nl>
Hi Jeroen,
On 28/10/14 01:45, Jeroen Hofstee wrote:
> Hello Nikita,
>
> Commit dc383dd introduces the following clang warning:
>
> drivers/block/dwc_ahsata.c:881:35: warning: use of logical '&&' with
> constant operand [-Wconstant-logical-operand]
> return readl(&(port_mmio->ssts)) && SATA_PORT_SSTS_DET_MASK;
> ^
> ~~~~~~~~~~~~~~~~~~~~~~~
> drivers/block/dwc_ahsata.c:881:35: note: use '&' for a bitwise operation
>
> Regards,
> Jeroen
Thanks for catching this. Indeed, this should be a bitwise AND. Patch
coming up.
--
Regards,
Nikita Kiryanov
prev parent reply other threads:[~2014-10-28 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 23:45 [U-Boot] clang warning Jeroen Hofstee
2014-10-28 12:58 ` Nikita Kiryanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544F92E4.6030305@compulab.co.il \
--to=nikita@compulab.co.il \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.