From: Guenter Roeck <linux@roeck-us.net>
To: netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Florian Fainelli <f.fainelli@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 09/15] net: dsa: Add support for switch EEPROM access
Date: Tue, 28 Oct 2014 06:31:40 -0700 [thread overview]
Message-ID: <544F9ABC.4010306@roeck-us.net> (raw)
In-Reply-To: <1414342365-27191-10-git-send-email-linux@roeck-us.net>
On 10/26/2014 09:52 AM, Guenter Roeck wrote:
> On some chips it is possible to access the switch eeprom.
> Add infrastructure support for it.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
[ ... ]
> @@ -603,6 +604,9 @@ static int dsa_of_probe(struct platform_device *pdev)
> if (pd->nr_chips > DSA_MAX_SWITCHES)
> pd->nr_chips = DSA_MAX_SWITCHES;
>
> + if (!of_property_read_u32(np, "eeprom-length", &eeprom_length))
> + pd->eeprom_length = eeprom_length;
This is buggy; please don't apply. Variable is named eeprom_len, and it is
per switch.
Lesson to self: When writing devicetree code, compile it with devicetree enabled.
Guenter
next prev parent reply other threads:[~2014-10-28 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-26 16:52 [PATCH v2 00/15] net: dsa: Fixes and enhancements Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 01/15] net: dsa: Don't set skb->protocol on outgoing tagged packets Guenter Roeck
2014-10-28 19:19 ` Florian Fainelli
2014-10-28 19:23 ` Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 02/15] net: dsa: Report known silicon revisions for Marvell 88E6060 Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 03/15] net: dsa: Report known silicon revisions for Marvell 88E6131 Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 04/15] net: dsa: Add support for Marvell 88E6352 Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 05/15] net: dsa/mv88e6352: Add support for MV88E6176 Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 06/15] net: dsa: Add support for reporting switch chip temperatures Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 07/15] net: dsa/mv88e6352: Report chip temperature Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 08/15] net: dsa/mv88e6123_61_65: " Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 09/15] net: dsa: Add support for switch EEPROM access Guenter Roeck
2014-10-27 2:41 ` Andrew Lunn
2014-10-27 3:56 ` Guenter Roeck
2014-10-27 8:50 ` Richard Cochran
2014-10-27 13:22 ` Guenter Roeck
2014-10-27 13:59 ` Andrew Lunn
2014-10-27 15:42 ` Guenter Roeck
2014-10-28 13:31 ` Guenter Roeck [this message]
2014-10-28 16:49 ` [PATCH v3 " Guenter Roeck
2014-10-28 18:19 ` David Miller
2014-10-28 19:21 ` Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 10/15] dsa: Add new optional devicetree property to describe EEPROM size Guenter Roeck
2014-10-28 16:50 ` [PATCH v3 " Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 11/15] net: dsa/mv88e6352: Implement EEPROM access functions Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 12/15] net: dsa: Add support for reading switch registers with ethtool Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 13/15] net: dsa/mv88e6123_61_65: Add support for reading switch registers Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 14/15] net: dsa/mv88e6352: " Guenter Roeck
2014-10-26 16:52 ` [PATCH v2 15/15] net: dsa: Provide additional RMON statistics Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544F9ABC.4010306@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.