From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: fio rbd completions (Was: fio rbd hang for block sizes > 1M) Date: Tue, 28 Oct 2014 09:14:58 -0600 Message-ID: <544FB2F2.2060703@kernel.dk> References: <5449BBB3.7090109@catalyst.net.nz> <544AEAE7.6080603@redhat.com> <544AF0D2.1050405@catalyst.net.nz> <544B0C7F.4080109@catalyst.net.nz> <544B1D50.4010101@kernel.dk> <544B2C19.7070009@catalyst.net.nz> <544BF808.2090800@kernel.dk> <544C2371.1020403@catalyst.net.nz> <544E547C.30009@kernel.dk> <544E6330.1000202@kernel.dk> <544E63EA.1010204@kernel.dk> <544E6691.106@kernel.dk> <544E6A8D.1040608@kernel.dk> <544EC05D.7040807@catalyst.net.nz> <544EC7F1.6010900@kernel.dk> <544ED37D.6060800@catalyst.net.nz> <79432849-2F58-4738-82E1-E4D8AB10A6AE@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: fio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ketor D Cc: Mark Kirkwood , Mark Nelson , Mark Nelson , "fio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "xan.peng" , "ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: ceph-devel.vger.kernel.org On 2014-10-27 22:49, Ketor D wrote: > Agree. Busy loop is only for test. > I will try the current git. Committed two more rbd changes: - Add support for rbd_invalidate_cache() (if it exists) - Use rbd_aio_is_complete() instead of using fri->io_complete. The latter should have some locking to ensure it's always seen, so it's better to use the API provided function to determine whether this IO is done or not. Unless we often hit the complete race, I would not expect this to make much of a difference. But it's worth testing in any case, especially since my two attempts at setting up ceph + rbd have failed miserably. So I still can't test myself. -- Jens Axboe From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <544FB2F2.2060703@kernel.dk> Date: Tue, 28 Oct 2014 09:14:58 -0600 From: Jens Axboe MIME-Version: 1.0 Subject: Re: fio rbd completions (Was: fio rbd hang for block sizes > 1M) References: <5449BBB3.7090109@catalyst.net.nz> <544AEAE7.6080603@redhat.com> <544AF0D2.1050405@catalyst.net.nz> <544B0C7F.4080109@catalyst.net.nz> <544B1D50.4010101@kernel.dk> <544B2C19.7070009@catalyst.net.nz> <544BF808.2090800@kernel.dk> <544C2371.1020403@catalyst.net.nz> <544E547C.30009@kernel.dk> <544E6330.1000202@kernel.dk> <544E63EA.1010204@kernel.dk> <544E6691.106@kernel.dk> <544E6A8D.1040608@kernel.dk> <544EC05D.7040807@catalyst.net.nz> <544EC7F1.6010900@kernel.dk> <544ED37D.6060800@catalyst.net.nz> <79432849-2F58-4738-82E1-E4D8AB10A6AE@kernel.dk> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Ketor D Cc: Mark Kirkwood , Mark Nelson , Mark Nelson , "fio@vger.kernel.org" , "xan.peng" , "ceph-devel@vger.kernel.org" List-ID: On 2014-10-27 22:49, Ketor D wrote: > Agree. Busy loop is only for test. > I will try the current git. Committed two more rbd changes: - Add support for rbd_invalidate_cache() (if it exists) - Use rbd_aio_is_complete() instead of using fri->io_complete. The latter should have some locking to ensure it's always seen, so it's better to use the API provided function to determine whether this IO is done or not. Unless we often hit the complete race, I would not expect this to make much of a difference. But it's worth testing in any case, especially since my two attempts at setting up ceph + rbd have failed miserably. So I still can't test myself. -- Jens Axboe