From: Santosh Shilimkar <santosh.shilimkar@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>, 'Bjorn Helgaas' <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org,
'Murali Karicheri' <m-karicheri2@ti.com>,
'Santosh Shilimkar' <ssantosh@kernel.org>
Subject: Re: [PATCH] PCI: keystone: make local symbol static
Date: Tue, 28 Oct 2014 09:36:26 -0700 [thread overview]
Message-ID: <544FC60A.4010603@gmail.com> (raw)
In-Reply-To: <000101cfee66$7d1ed040$775c70c0$%han@samsung.com>
On 10/22/2014 07:10 PM, Jingoo Han wrote:
> Make local symbol static, because this is used only in this file.
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/pci/host/pci-keystone-dw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/host/pci-keystone-dw.c b/drivers/pci/host/pci-keystone-dw.c
> index 34086ce..4a97cd1 100644
> --- a/drivers/pci/host/pci-keystone-dw.c
> +++ b/drivers/pci/host/pci-keystone-dw.c
> @@ -201,7 +201,7 @@ static int ks_dw_pcie_msi_map(struct irq_domain *domain, unsigned int irq,
> return 0;
> }
>
> -const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> +static const struct irq_domain_ops ks_dw_pcie_msi_domain_ops = {
> .map = ks_dw_pcie_msi_map,
> };
>
>
Looks correct.
FWIW, Acked-by: Santosh Shilimkar<ssantosh@kernel.org>
next prev parent reply other threads:[~2014-10-28 16:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 2:10 [PATCH] PCI: keystone: make local symbol static Jingoo Han
2014-10-27 18:06 ` Murali Karicheri
2014-10-28 16:36 ` Santosh Shilimkar [this message]
2014-10-29 16:08 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FC60A.4010603@gmail.com \
--to=santosh.shilimkar@gmail.com \
--cc=bhelgaas@google.com \
--cc=jg1.han@samsung.com \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.