From: Jens Axboe <axboe@kernel.dk>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: wrong return value
Date: Tue, 28 Oct 2014 11:26:39 -0600 [thread overview]
Message-ID: <544FD1CF.5000505@kernel.dk> (raw)
In-Reply-To: <20141028172234.GA12775@sudip-PC>
On 2014-10-28 11:22, Sudip Mukherjee wrote:
> On Thu, Oct 23, 2014 at 10:16:48PM +0530, Sudip Mukherjee wrote:
>> while compiling integer err was showing as a set but unused variable.
>> elevator_init_fn can be either cfq_init_queue or deadline_init_queue
>> or noop_init_queue.
>> all three of these functions are returning -ENOMEM if they fail to
>> allocate the queue.
>> so we should actually be returning the error code rather than
>> returning 0 always.
> i have one doubt. shouldn't this patch be marked for stable also?
It would not hurt to mark it as stable, but on the other hand, this
probably never triggered a problem for anyone. So it's not a critical
fix by any stretch.
--
Jens Axboe
prev parent reply other threads:[~2014-10-28 17:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 16:46 [PATCH v3] block: wrong return value Sudip Mukherjee
2014-10-28 17:22 ` Sudip Mukherjee
2014-10-28 17:26 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544FD1CF.5000505@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.