From mboxrd@z Thu Jan 1 00:00:00 1970 From: sbranden@broadcom.com (Scott Branden) Date: Tue, 28 Oct 2014 12:41:04 -0700 Subject: [PATCH v7 4/7] ARM: dts: Enable Broadcom Cygnus SoC In-Reply-To: <12464460.6zhqY1bzdG@wuerfel> References: <1414011474-11821-5-git-send-email-sbranden@broadcom.com> <12464460.6zhqY1bzdG@wuerfel> Message-ID: <544FF150.3090504@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Thanks for the review. Will send out v8 version. Hopefully for finally approval. On 14-10-28 09:10 AM, Arnd Bergmann wrote: > On Wednesday 22 October 2014 13:57:51 Scott Branden wrote: >> + >> + aliases { >> + serial0 = &uart3; >> + serial1 = &uart0; >> + }; >> + >> + chosen { >> + bootargs = "console=ttyS0,115200 earlyprintk debug"; >> + }; >> > > Please move the 'aliases' and 'chosen' node into the .dts files, these > are board specific, not SoC specific. ok. > > For chosen, please remove earlyprintk and debug, which don't normally > make sense unless you are debugging, and which will break in a multiplatform > kernel. ok. > > Please also add an "stdout-path = &uart3" property in chosen so that > earlycon can work. Note that earlycon is currently broken on arm32, > but we'll get there. ok. > > Arnd > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Branden Subject: Re: [PATCH v7 4/7] ARM: dts: Enable Broadcom Cygnus SoC Date: Tue, 28 Oct 2014 12:41:04 -0700 Message-ID: <544FF150.3090504@broadcom.com> References: <1414011474-11821-5-git-send-email-sbranden@broadcom.com> <12464460.6zhqY1bzdG@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <12464460.6zhqY1bzdG@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: Christian Daudt , Matt Porter , Russell King , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Mike Turquette , Alex Elder , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Andrew Morton , "David S. Miller" , Greg Kroah-Hartman , Joe Perches , Mauro Carvalho Chehab , Antti Palosaari , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ray Jui , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, JD Zheng List-Id: devicetree@vger.kernel.org Thanks for the review. Will send out v8 version. Hopefully for finally approval. On 14-10-28 09:10 AM, Arnd Bergmann wrote: > On Wednesday 22 October 2014 13:57:51 Scott Branden wrote: >> + >> + aliases { >> + serial0 = &uart3; >> + serial1 = &uart0; >> + }; >> + >> + chosen { >> + bootargs = "console=ttyS0,115200 earlyprintk debug"; >> + }; >> > > Please move the 'aliases' and 'chosen' node into the .dts files, these > are board specific, not SoC specific. ok. > > For chosen, please remove earlyprintk and debug, which don't normally > make sense unless you are debugging, and which will break in a multiplatform > kernel. ok. > > Please also add an "stdout-path = &uart3" property in chosen so that > earlycon can work. Note that earlycon is currently broken on arm32, > but we'll get there. ok. > > Arnd > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754550AbaJ1TlL (ORCPT ); Tue, 28 Oct 2014 15:41:11 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:46439 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbaJ1TlJ (ORCPT ); Tue, 28 Oct 2014 15:41:09 -0400 X-IronPort-AV: E=Sophos;i="5.04,804,1406617200"; d="scan'208";a="49344094" Message-ID: <544FF150.3090504@broadcom.com> Date: Tue, 28 Oct 2014 12:41:04 -0700 From: Scott Branden User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Arnd Bergmann , CC: Christian Daudt , Matt Porter , Russell King , , Mike Turquette , Alex Elder , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Andrew Morton , "David S. Miller" , Greg Kroah-Hartman , Joe Perches , "Mauro Carvalho Chehab" , Antti Palosaari , , Ray Jui , , JD Zheng Subject: Re: [PATCH v7 4/7] ARM: dts: Enable Broadcom Cygnus SoC References: <1414011474-11821-5-git-send-email-sbranden@broadcom.com> <12464460.6zhqY1bzdG@wuerfel> In-Reply-To: <12464460.6zhqY1bzdG@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks for the review. Will send out v8 version. Hopefully for finally approval. On 14-10-28 09:10 AM, Arnd Bergmann wrote: > On Wednesday 22 October 2014 13:57:51 Scott Branden wrote: >> + >> + aliases { >> + serial0 = &uart3; >> + serial1 = &uart0; >> + }; >> + >> + chosen { >> + bootargs = "console=ttyS0,115200 earlyprintk debug"; >> + }; >> > > Please move the 'aliases' and 'chosen' node into the .dts files, these > are board specific, not SoC specific. ok. > > For chosen, please remove earlyprintk and debug, which don't normally > make sense unless you are debugging, and which will break in a multiplatform > kernel. ok. > > Please also add an "stdout-path = &uart3" property in chosen so that > earlycon can work. Note that earlycon is currently broken on arm32, > but we'll get there. ok. > > Arnd >