From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christian Emmerich Date: Thu, 01 Nov 2007 11:27:53 +0000 Subject: Re: [lm-sensors] hwmon/f75375s.c: buggy if() Message-Id: <545004.44336.qm@web25107.mail.ukl.yahoo.com> MIME-Version: 1 Content-Type: multipart/mixed; boundary="===============1092647018866716984==" List-Id: References: <20071017195439.GD3778@stusta.de> In-Reply-To: <20071017195439.GD3778@stusta.de> To: lm-sensors@vger.kernel.org --===============1092647018866716984== Content-Type: multipart/alternative; boundary="0-1130056255-1193916473=:44336" Content-Transfer-Encoding: 8bit --0-1130056255-1193916473=:44336 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi > Hi: >=20 > * Riku Voipio [2007-10-26 14:14:23 +0300]: > > On Fri, Oct 26, 2007 at 10:36:47AM +0200, Jean Delvare wrote: > > > Patch looks correct, however it doesn't apply on top of Mark's tree. I > > > was able to get it to apply by reverting "(f75375s) fix pwm mode > > > setting" first, but then the build fails. Presumably the other f75375s > > > patches interact badly. Can you please respin this patch on top of > > > Mark's tree (i.e. on top the the 4 other f75375s patches you sent sin= ce > > > the -rc1 merge)? Thanks. > >=20 > > The surrounding code had wandered to another function, so it's suprising > > it applied at all. Here's respin. > >=20 > > --=20 > > "rm -rf" only sounds scary if you don't have backups >=20 > > >From 4de69e3ab5b5833cddb503f0dcb2a3ccc2d5b328 Mon Sep 17 00:00:00 > 20= 01 > > From: Riku Voipio=20 > > Date: Fri, 26 Oct 2007 13:53:50 +0300 > > Subject: [PATCH] hwmon (f75375s) fix buggy if() properly > >=20 > > Fix value check in set_pwm_mode(). Instead of checking for > > chip variant there, make pwmX_mode sysfs nodes only writable > > on f75375 variant. > >=20 > > Signed-off-by: Riku Voipio=20 > > --- > > drivers/hwmon/f75375s.c | 19 ++++++++++++++++--- > > 1 files changed, 16 insertions(+), 3 deletions(-) > >=20 >=20 > Applied to hwmon-2.6.git/testing, thanks. >=20 > --=20 > Mark M. Hoffman > mhoffman@lightlink.com Don't know if necessary, but i tested the driver using kernel 2.6.22-14, dr= iver from kernel/mhoffman/hwmon-2.6.git - testing (28 Oct) and sensors vers= ion 3.0.0-rc3 with libsensors version 3.0.0-rc3.=20 Fan-Speed, temperatures and voltage is displayed correctly. I can also chan= ge the fan speed without problem. The only modification i made in lm-sensors, setting the value of driver to = "f75375s" in prog/detect/sensors-detect for "Fintek F75373S/SG". best regards christian. =20 --------------------------------- Ihr erstes Fernweh? Wo gibt es den sch=F6nsten Strand.=20 --0-1130056255-1193916473=:44336 Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Hi

> Hi:
>
> * Riku Voipio [2007-10-26 14:14:23 += 0300]:
> > On Fri, Oct 26, 2007 at 10:36:47AM +0200, Jean Delvar= e wrote:
> > > Patch looks correct, however it doesn't apply = on top of Mark's tree. I
> > > was able to get it to apply by= reverting "(f75375s) fix pwm mode
> > > setting" first, but = then the build fails. Presumably the other f75375s
> > > patches interact badly. Can you please respin = this patch on top of
> > > Mark's tree (i.e. on top the the = 4 other f75375s patches you sent since
> > > the -rc1 merge)?= Thanks.
> >
> > The surrounding code had wandered t= o another function, so it's suprising
> > it applied at all. Her= e's respin.
> >
> > --
> > "rm -rf" only sounds scary if you don't have backups
= >
> > >From 4de69e3ab5b5833cddb503f0dcb2a3ccc2d5b328 Mon = Sep 17 00:00:00 > 2001
> > From: Riku Voipio
> > = Date: Fri, 26 Oct 2007 13:53:50 +0300
> > Subject: [PATCH] hwmon= (f75375s) fix buggy if() properly
> >
> > Fix valu= e check in set_pwm_mode(). Instead of checking for
> > chip variant there, make pwmX_mode sysfs node= s only writable
> > on f75375 variant.
> > >= ; > Signed-off-by: Riku Voipio
> > ---
> > drive= rs/hwmon/f75375s.c | 19 ++++++++++++++++---
> > 1 files chang= ed, 16 insertions(+), 3 deletions(-)
> >
>
> Applied to hwmon-2.6.git/testing, thanks.=
&= gt;
> --
> Mark M. Hoffman
> mhoffman@lightlink.c= om

Don't know if necessary, but i tested the driver using kernel 2= .6.22-14, driver from kernel/mhoffman/hwmon-2.6.git - testing (28 Oct) and = sensors version 3.0.0-rc3 with libsensors version 3.0.0-rc3.

Fan= -Speed, temperatures and voltage is displayed correctly. I can also change = the fan speed without problem.
The = only modification i made in lm-sensors, setting the value of driver to "f75= 375s" in prog/detect/sensors-detect for "Fintek F75373S/SG".

best regards
christian.

Ihr erstes Fernweh? Wo gibt es den sch=F6nsten Strand. --0-1130056255-1193916473=:44336-- --===============1092647018866716984== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors --===============1092647018866716984==--