From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= Subject: Re: [PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect Date: Wed, 29 Oct 2014 12:03:33 +0900 Message-ID: <54505905.9020501@daenzer.net> References: <88c64cce88264069e0e1637fc874e699e5b226f6.1414387334.git.joe@perches.com> <544E0D0E.6080206@daenzer.net> <1414419297.8884.5.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail.gna.ch (darkcity.gna.ch [195.226.6.51]) by gabe.freedesktop.org (Postfix) with ESMTP id D16A46E397 for ; Tue, 28 Oct 2014 20:03:41 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Alex Deucher , Joe Perches Cc: LKML , Maling list - DRI developers List-Id: dri-devel@lists.freedesktop.org T24gMjguMTAuMjAxNCAyMzowNiwgQWxleCBEZXVjaGVyIHdyb3RlOgo+IE9uIE1vbiwgT2N0IDI3 LCAyMDE0IGF0IDEwOjE0IEFNLCBKb2UgUGVyY2hlcyA8am9lQHBlcmNoZXMuY29tPiB3cm90ZToK Pj4gUHJlY2VkZW5jZSBvZiAmIGFuZCA+PiBpcyBub3QgdGhlIHNhbWUgYW5kIGlzIG5vdCBsZWZ0 IHRvIHJpZ2h0Lgo+PiBzaGlmdCBoYXMgaGlnaGVyIHByZWNlZGVuY2UgYW5kIHNob3VsZCBiZSBk b25lIGFmdGVyIHRoZSBtYXNrLgo+Pgo+PiBBZGQgcGFyZW50aGVzZXMgYXJvdW5kIHRoZSBtYXNr Lgo+Pgo+PiBVc2UgdGhlIGFscmVhZHkgI2RlZmluZWQgdmFsdWVzIGluc3RlYWQgb2YgaGFyZGNv ZGluZy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSm9lIFBlcmNoZXMgPGpvZUBwZXJjaGVzLmNvbT4K Pj4gLS0tCj4+PiBJIHRoaW5rIHRoaXMgc2hvdWxkIGJlIE5VTV9TSEFERVJfRU5HSU5FU19TSElG VD8KPj4KPj4gKEpvZSBjYW4ndCB0eXBlKQo+Pgo+PiBleGFjdGx5IHJpZ2h0LCB0aGFua3MgTWlj aGVsCj4KPiBBcHBsaWVkIHdpdGggYSBjb21waWxlIGZpeC4KCkpvZSwgaW4gdGhlIGZ1dHVyZSBw bGVhc2UgbWFrZSBzdXJlIHlvdXIgcGF0Y2hlcyBjb21waWxlIGJlZm9yZSAKc3VibWl0dGluZyB0 aGVtLgoKCi0tIApFYXJ0aGxpbmcgTWljaGVsIETDpG56ZXIgICAgICAgICAgICB8ICAgICAgICAg ICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCkxpYnJlIHNvZnR3YXJlIGVudGh1c2lhc3QgICAg ICAgICAgfCAgICAgICAgICAgICAgICBNZXNhIGFuZCBYIGRldmVsb3BlcgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754537AbaJ2DDo (ORCPT ); Tue, 28 Oct 2014 23:03:44 -0400 Received: from darkcity.gna.ch ([195.226.6.51]:55132 "EHLO mail.gna.ch" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751993AbaJ2DDn (ORCPT ); Tue, 28 Oct 2014 23:03:43 -0400 Message-ID: <54505905.9020501@daenzer.net> Date: Wed, 29 Oct 2014 12:03:33 +0900 From: =?UTF-8?Q?Michel_D=c3=a4nzer?= User-Agent: Mozilla/5.0 (X11; Linux ppc; rv:32.0) Gecko/20100101 Icedove/32.0 MIME-Version: 1.0 To: Alex Deucher , Joe Perches CC: Maling list - DRI developers , LKML Subject: Re: [PATCH 02/11 V2] radeon: evergreen: Fix probable mask then right shift defect References: <88c64cce88264069e0e1637fc874e699e5b226f6.1414387334.git.joe@perches.com> <544E0D0E.6080206@daenzer.net> <1414419297.8884.5.camel@perches.com> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28.10.2014 23:06, Alex Deucher wrote: > On Mon, Oct 27, 2014 at 10:14 AM, Joe Perches wrote: >> Precedence of & and >> is not the same and is not left to right. >> shift has higher precedence and should be done after the mask. >> >> Add parentheses around the mask. >> >> Use the already #defined values instead of hardcoding. >> >> Signed-off-by: Joe Perches >> --- >>> I think this should be NUM_SHADER_ENGINES_SHIFT? >> >> (Joe can't type) >> >> exactly right, thanks Michel > > Applied with a compile fix. Joe, in the future please make sure your patches compile before submitting them. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer