From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f175.google.com ([209.85.192.175]:37899 "EHLO mail-pd0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbaJ2Dme (ORCPT ); Tue, 28 Oct 2014 23:42:34 -0400 Received: by mail-pd0-f175.google.com with SMTP id y13so2098461pdi.6 for ; Tue, 28 Oct 2014 20:42:34 -0700 (PDT) Message-ID: <5450617B.8030700@gmail.com> Date: Wed, 29 Oct 2014 09:09:39 +0530 From: Varka Bhadram MIME-Version: 1.0 Subject: Re: [PATCH bluetooth-next 01/17] mac802154: monitor: merge into iface implementation References: <1414516892-4107-1-git-send-email-alex.aring@gmail.com> <1414516892-4107-2-git-send-email-alex.aring@gmail.com> In-Reply-To: <1414516892-4107-2-git-send-email-alex.aring@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Alexander Aring , linux-wpan@vger.kernel.org Cc: kernel@pengutronix.de On 10/28/2014 10:51 PM, Alexander Aring wrote: > This patch removes the monitor implementation file and put all monitor > stuff into iface file. It's now small enough to put all necessary > handling into iface. > > Signed-off-by: Alexander Aring > --- > net/mac802154/Makefile | 2 +- > net/mac802154/iface.c | 30 +++++++++++++++++++++++++ > net/mac802154/monitor.c | 59 ------------------------------------------------- > 3 files changed, 31 insertions(+), 60 deletions(-) > delete mode 100644 net/mac802154/monitor.c > Hi Alex, Doing nice work,changing the code view same as mac80211. But What ever you do in previous patches you are undoing, like moving some of the code to iface file from their to main file like that... Please correct me if I am wrong. -- Regards, Varka Bhadram.