From: Matthias Klein <matthias.klein@linux.com>
To: Stephen Warren <swarren@wwwdotorg.org>,
linux-rpi-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: bcm2835: add device tree for Raspberry Pi model B+
Date: Wed, 29 Oct 2014 10:07:59 +0100 [thread overview]
Message-ID: <5450AE6F.8010102@linux.com> (raw)
In-Reply-To: <54504407.3090700@wwwdotorg.org>
Am 29.10.2014 um 02:33 schrieb Stephen Warren:
> On 10/27/2014 06:52 PM, Matthias Klein wrote:
>> The model B and B+ differ in the GPIO lines for ACT and PWR led.
>> The PWR led on the B+ model is active low.
> This new file is almost identical to bcm2835-rpi.dts. Perhaps we can use
> some include files to share the common portions so they aren't
> duplicated. Roughly:
>
> * Move all the common content from bcm2835-rpi.dts into bcm2835-rpi.dtsi.
>
> * Update bcm2835-rpi.dts to include bcm2835-rpi.dtsi to get all the
> common parts, and add the few lines of differences.
>
> * Update this patch similarly.
>
> Does that make sense?
Yes, I will work on such a patchset.
>
> A couple changes to this patch and the existing bcm2835-rpi.dts might
> reduce the differences even further, leading to more common code in
> bcm2835-rpi.dtsi:
>
> - Add the PWR LED to bcm2835-rpi-b.dts, if appropriate.
> - Add the I2S pinmux settings for B+ too.
>
>> diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
> ...
>> +&mmc {
> That label doesn't exist; it should be &sdhci. Consequently:
Sorry, I based my patch on the wrong tree. I used
https://github.com/pietrushnic/rpi-dt-linux/tree/rpi-3.17.y which
contains non upstream commits.
Which tree should I use in general for work on the BCM2835? Is
linux-next the right tree?
next prev parent reply other threads:[~2014-10-29 9:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-28 0:52 [PATCH] ARM: bcm2835: add device tree for Raspberry Pi model B+ Matthias Klein
2014-10-29 1:33 ` Stephen Warren
2014-10-29 9:07 ` Matthias Klein [this message]
2014-10-29 16:40 ` Stephen Warren
-- strict thread matches above, loose matches on Subject: below --
2014-11-20 10:52 [PATCH] ARM: bcm2835: Add " Lee Jones
2014-11-20 10:52 ` Lee Jones
2014-11-20 11:18 ` Arnd Bergmann
2014-11-20 11:18 ` Arnd Bergmann
2014-11-20 11:22 ` Lee Jones
2014-11-20 11:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5450AE6F.8010102@linux.com \
--to=matthias.klein@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.