From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Wed, 29 Oct 2014 10:22:03 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:40669 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011540AbaJ2JWCFe93B (ORCPT ); Wed, 29 Oct 2014 10:22:02 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 73E932C4511BF; Wed, 29 Oct 2014 09:21:52 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 09:21:53 +0000 Received: from [192.168.154.101] (192.168.154.101) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Wed, 29 Oct 2014 09:21:53 +0000 Message-ID: <5450B1B1.5070301@imgtec.com> Date: Wed, 29 Oct 2014 09:21:53 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 MIME-Version: 1.0 To: Andrew Bresticker , Ralf Baechle , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , "Thomas Gleixner" , Jason Cooper , "Daniel Lezcano" CC: John Crispin , David Daney , Qais Yousef , , , Subject: Re: [PATCH V3 2/4] of: Add binding document for MIPS GIC References: <1414541562-10076-1-git-send-email-abrestic@chromium.org> <1414541562-10076-3-git-send-email-abrestic@chromium.org> In-Reply-To: <1414541562-10076-3-git-send-email-abrestic@chromium.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43695 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Andrew, On 29/10/14 00:12, Andrew Bresticker wrote: > - changed compatible string to include CPU version > +Required properties: > +- compatible : Should be "mti,-gic". Supported variants: > + - "mti,interaptiv-gic" > +Required properties for timer sub-node: > +- compatible : Should be "mti,-gic-timer". Supported variants: > + - "mti,interaptiv-gic-timer" Erm, I'm a bit confused... Why do you include the core name in the compatible string? You seem to be suggesting that: 1) The GIC/timer drivers need to know what core they're running on. Is that really true? 2) It isn't possible to probe the core type. But the kernel already knows this, so what's wrong with using current_cpu_type() like everything else that needs to know? 3) Every new core should require a new compatible string to be added before the GIC will work. You don't even have a generic compatible string that DT can specify after the core specific one as a fallback. Please lets not do this unless it's actually necessary (which AFAICT it really isn't). Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:40669 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011540AbaJ2JWCFe93B (ORCPT ); Wed, 29 Oct 2014 10:22:02 +0100 Message-ID: <5450B1B1.5070301@imgtec.com> Date: Wed, 29 Oct 2014 09:21:53 +0000 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH V3 2/4] of: Add binding document for MIPS GIC References: <1414541562-10076-1-git-send-email-abrestic@chromium.org> <1414541562-10076-3-git-send-email-abrestic@chromium.org> In-Reply-To: <1414541562-10076-3-git-send-email-abrestic@chromium.org> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Andrew Bresticker , Ralf Baechle , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Jason Cooper , Daniel Lezcano Cc: John Crispin , David Daney , Qais Yousef , linux-mips@linux-mips.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20141029092153.X5Ss5hsPhds-qcVv2rT0Fi2SAndKjf7aLWxB5yEuf0E@z> Hi Andrew, On 29/10/14 00:12, Andrew Bresticker wrote: > - changed compatible string to include CPU version > +Required properties: > +- compatible : Should be "mti,-gic". Supported variants: > + - "mti,interaptiv-gic" > +Required properties for timer sub-node: > +- compatible : Should be "mti,-gic-timer". Supported variants: > + - "mti,interaptiv-gic-timer" Erm, I'm a bit confused... Why do you include the core name in the compatible string? You seem to be suggesting that: 1) The GIC/timer drivers need to know what core they're running on. Is that really true? 2) It isn't possible to probe the core type. But the kernel already knows this, so what's wrong with using current_cpu_type() like everything else that needs to know? 3) Every new core should require a new compatible string to be added before the GIC will work. You don't even have a generic compatible string that DT can specify after the core specific one as a fallback. Please lets not do this unless it's actually necessary (which AFAICT it really isn't). Thanks James