From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjQXO-0004Ns-I3 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:31:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XjQXH-0005me-E4 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:31:34 -0400 Received: from szxga01-in.huawei.com ([119.145.14.64]:64061) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XjQXH-0005lt-25 for qemu-devel@nongnu.org; Wed, 29 Oct 2014 06:31:27 -0400 Message-ID: <5450C19C.4090909@huawei.com> Date: Wed, 29 Oct 2014 18:29:48 +0800 From: Gonglei MIME-Version: 1.0 References: <1414577839-18695-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1414577839-18695-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] virtio: link the rng backend through an alias property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org On 2014/10/29 18:17, Paolo Bonzini wrote: > The virtio-rng backend is currently linked twice, once in the proxy > device (e.g. virtio-rng-pci) and once in virtio-rng-device. This causes > a double unref of the backend when the parent device is unplugged. > > To fix this, make the proxy device use an alias, similar to what is > already being done for the iothread link. > > Signed-off-by: Paolo Bonzini > > --- > v1->v2: also change s390-virtio-bus.c (Gonglei) > --- > hw/s390x/s390-virtio-bus.c | 6 ++---- > hw/s390x/virtio-ccw.c | 6 ++---- > hw/virtio/virtio-pci.c | 7 ++----- > 3 files changed, 6 insertions(+), 13 deletions(-) Reviewed-by: Gonglei Best regards, -Gonglei