All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nikita Kiryanov <nikita@compulab.co.il>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] common: introduce board_preboot_os hook
Date: Wed, 29 Oct 2014 17:34:59 +0200	[thread overview]
Message-ID: <54510923.3080802@compulab.co.il> (raw)
In-Reply-To: <CAP9ODKre_XWRR6naFmdaz9OKpxFgJNy9sAeZsY_YNh-wWEJ68Q@mail.gmail.com>

Hi Jeroen, Otavio,

On 29/10/14 17:23, Otavio Salvador wrote:
> On Wed, Oct 29, 2014 at 11:28 AM, Jeroen Hofstee <jeroen@myspectrum.nl> wrote:
>> On 29-10-14 14:08, Nikita Kiryanov wrote:
>>>
>>> Introduce board specific function board_preboot_os() to allow for board
>>> specific config before we boot, and use it on cm_fx6 to power off sata
>>> so that Linux will be able to setup it correctly.
>>>
>>> Signed-off-by: Nikita Kiryanov <nikita@compulab.co.il>
>>> Cc: Igor Grinberg <grinberg@compulab.co.il>
>>> Cc: Stefano Babic <sbabic@denx.de>
>>> Cc: Tom Rini <trini@ti.com>
>>
>> ..
>>>
>>> +
>>> +void board_preboot_os(void)
>>> +{
>>> +       cm_fx6_sata_power(0);
>>> +}
>>>    +/* Allow for board specific config before we boot */
>>> +__weak void board_preboot_os(void)
>>> +{
>>> +       /* please define board specific board_preboot_os() */
>>> +}
>>> +
>>>    int boot_selected_os(int argc, char * const argv[], int state,
>>>                       bootm_headers_t *images, boot_os_fn *boot_fn)
>>>    {
>>>          arch_preboot_os();
>>> +       board_preboot_os();
>>>          boot_fn(state, argc, argv, images);
>>
>>
>> Can you also add a prototype for the board_preboot_os in say
>> bootm.h or similiar and make sure those headers are included.
>> (it will warn otherwise with W=1).
>

Sure.

> and also split the patch in two.
>

Alright.

-- 
Regards,
Nikita Kiryanov

      reply	other threads:[~2014-10-29 15:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 13:08 [U-Boot] [PATCH 0/3] cm-fx6 updates Nikita Kiryanov
2014-10-29 13:08 ` [U-Boot] [PATCH 1/3] arm: mx6: cm_fx6: change issd gpio order Nikita Kiryanov
2014-10-29 13:08 ` [U-Boot] [PATCH 2/3] arm: mx6: cm_fx6: detect 1GB DRAM correctly on solo Nikita Kiryanov
2014-10-29 13:08 ` [U-Boot] [PATCH 3/3] common: introduce board_preboot_os hook Nikita Kiryanov
2014-10-29 13:28   ` Jeroen Hofstee
2014-10-29 15:23     ` Otavio Salvador
2014-10-29 15:34       ` Nikita Kiryanov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54510923.3080802@compulab.co.il \
    --to=nikita@compulab.co.il \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.