Re: [PATCH 2/2] xfsprogs: don't warn about log sunit size if it was auto-discovered

[Eric Sandeen <sandeen@sandeen.net>]

On 10/29/14 1:38 PM, Brian Foster wrote:
> On Tue, Oct 28, 2014 at 12:38:05PM -0500, Eric Sandeen wrote:
>> Today, users doing a bare mkfs on storage with a large default
>> stripe size may be surprised to get this warning:
>>
>>  log stripe unit (%d bytes) is too large (maximum is 256KiB
>>  log stripe unit adjusted to 32KiB
>>
>> through no fault of their own.  The fallback is appropriate
>> and harmless, and there's no need to warn about this in the
>> defaults case.
>>
>> However, we keep the warning if a large log stripe unit was
>> specified by the user on the commandline.
>>
>> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>> ---
...

>> @@ -2379,11 +2383,15 @@ an AG size that is one stripe unit smaller, for example %llu.\n"),
>>  	}
>>  
>>  	if (logversion == 2 && (lsunit * blocksize) > 256 * 1024) {
>> -		fprintf(stderr,
>> +		/* Warn only if specified on commandline */
>> +		if (lsuflag || lsunitflag) {
>> +			fprintf(stderr,
>>  	_("log stripe unit (%d bytes) is too large (maximum is 256KiB)\n"),
>> -			(lsunit * blocksize));
>> +				(lsunit * blocksize));
>> +			fprintf(stderr,
>> +	_("log stripe unit adjusted to 32KiB\n"));
>> +		}
> 
> Right above this particular hunk we have the possibility of lsunit
> inheriting a value from dsunit. If the latter is specified by the user,
> we don't print the message for an arguably user-specified lsunit. Hmm,
> do we care about that case?

I don't think we do care.  I think we only care if the user manually
specified a log stripe unit and we're changing what they asked for.

I'd put "inheritance" in the "using default behaviors" case, and not
warn about it.

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs