From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35426)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XjfVP-0003bj-3I
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 22:30:40 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XjfVG-0001Qf-0H
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 22:30:31 -0400
Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:56941)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1XjfVF-0001QU-PG
	for qemu-devel@nongnu.org; Wed, 29 Oct 2014 22:30:21 -0400
Received: by mail-pd0-f174.google.com with SMTP id p10so4177077pdj.33
	for <qemu-devel@nongnu.org>; Wed, 29 Oct 2014 19:30:20 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5451A2B9.7040607@twiddle.net>
Date: Wed, 29 Oct 2014 19:30:17 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1414588941-845-1-git-send-email-kbastian@mail.uni-paderborn.de>
	<1414588941-845-5-git-send-email-kbastian@mail.uni-paderborn.de>
In-Reply-To: <1414588941-845-5-git-send-email-kbastian@mail.uni-paderborn.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/5] target-tricore: Add instructions of
	BRR opcode format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org

On 10/29/2014 06:22 AM, Bastian Koppelmann wrote:
> +    case OPCM_32_BRR_LOOP:
> +        if (MASK_OP_BRR_OP2(ctx->opcode) == OPC2_32_BRR_LOOP) {
> +            gen_loop(ctx, r1, offset * 2);
> +        } else {
> +            gen_save_pc(ctx->pc + offset * 2);
> +        }

gen_goto_tb.  Also worth a comment that this is LOOPU.


r~