From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data Date: Thu, 30 Oct 2014 08:31:00 +0100 Message-ID: <5451E934.6010902@suse.de> References: <20141027052607.105914311@telegraphics.com.au> <20141027052610.275439151@telegraphics.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20141027052610.275439151@telegraphics.com.au> Sender: linux-scsi-owner@vger.kernel.org To: Finn Thain , "James E.J. Bottomley" Cc: Michael Schmitz , Sam Creasey , linux-scsi@vger.kernel.org, linux-m68k@vger.kernel.org, Russell King , linux-arm-kernel@lists.infradead.org List-Id: linux-m68k@vger.kernel.org On 10/27/2014 06:26 AM, Finn Thain wrote: > Static variables from dtc.c and pas16.c should not appear in the core > NCR5380.c driver. Aside from being a layering issue this worsens the > divergence between the three core driver variants (atari_NCR5380.c an= d > sun3_NCR5380.c don't support PSEUDO_DMA) and it can mean multiple hos= ts > share the same counters. >=20 > Fix this by making the pseudo DMA spin counters in the core more gene= ric. > This also avoids the abuse of the {DTC,PAS16}_PUBLIC_RELEASE macros, = so > they can be removed. >=20 > oak.c doesn't use PDMA and hence it doesn't use the counters and henc= e it > needs no write_info() method. Remove it. >=20 > Signed-off-by: Finn Thain >=20 Reviewed-by: Hannes Reinecke Cheers, Hannes --=20 Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg GF: J. Hawn, J. Guild, F. Imend=F6rffer, HRB 16746 (AG N=FCrnberg) -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: hare@suse.de (Hannes Reinecke) Date: Thu, 30 Oct 2014 08:31:00 +0100 Subject: [PATCH v2 13/36] ncr5380: Move static PDMA spin counters to host data In-Reply-To: <20141027052610.275439151@telegraphics.com.au> References: <20141027052607.105914311@telegraphics.com.au> <20141027052610.275439151@telegraphics.com.au> Message-ID: <5451E934.6010902@suse.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/27/2014 06:26 AM, Finn Thain wrote: > Static variables from dtc.c and pas16.c should not appear in the core > NCR5380.c driver. Aside from being a layering issue this worsens the > divergence between the three core driver variants (atari_NCR5380.c and > sun3_NCR5380.c don't support PSEUDO_DMA) and it can mean multiple hosts > share the same counters. > > Fix this by making the pseudo DMA spin counters in the core more generic. > This also avoids the abuse of the {DTC,PAS16}_PUBLIC_RELEASE macros, so > they can be removed. > > oak.c doesn't use PDMA and hence it doesn't use the counters and hence it > needs no write_info() method. Remove it. > > Signed-off-by: Finn Thain > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare at suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg GF: J. Hawn, J. Guild, F. Imend?rffer, HRB 16746 (AG N?rnberg)