From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Kirkwood Subject: Re: fio rbd completions (Was: fio rbd hang for block sizes > 1M) Date: Thu, 30 Oct 2014 20:44:35 +1300 Message-ID: <5451EC63.9070600@catalyst.net.nz> References: <5449BBB3.7090109@catalyst.net.nz> <544E6330.1000202@kernel.dk> <544E63EA.1010204@kernel.dk> <544E6691.106@kernel.dk> <544E6A8D.1040608@kernel.dk> <544EC05D.7040807@catalyst.net.nz> <544EC7F1.6010900@kernel.dk> <544ED37D.6060800@catalyst.net.nz> <79432849-2F58-4738-82E1-E4D8AB10A6AE@kernel.dk> <544FB2F2.2060703@kernel.dk> <544FCDBD.7070106@kernel.dk> <5450FA47.2030203@kernel.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bertrand.catalyst.net.nz ([202.78.240.40]:40093 "EHLO mail.catalyst.net.nz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757832AbaJ3Hoj (ORCPT ); Thu, 30 Oct 2014 03:44:39 -0400 In-Reply-To: <5450FA47.2030203@kernel.dk> Sender: ceph-devel-owner@vger.kernel.org List-ID: To: Jens Axboe , Ketor D Cc: Mark Nelson , Mark Nelson , "fio@vger.kernel.org" , "xan.peng" , "ceph-devel@vger.kernel.org" On 30/10/14 03:31, Jens Axboe wrote: > On 2014-10-29 01:15, Ketor D wrote: >> Hi, Jens, >> >> There is cmdline parse bug in the fio rbd test. >> >> I have fixed this and create a pull request on the github. >> >> Please review. >> >> After fix the bugs, the fio test can run. > > I merged your two pull requests (thanks!) and committed a polished > variant of the sort patch. Ketor and Mark, would you mind both running a > quick benchmark on the current -git head? > Better late than never (sorry), comparing with the 'original' fio code containing the usleep(100): blocksize k | head iops | orig iops ------------+---------------+-------------- 4 | 11114 | 11516 128 | 4551 | 6550 1024 | 1195 | 1248 So we do pretty much the same except in the middle blocksize range (I checked again with the old binary just to rule out any other changes on the ceph end...). Regards Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <5451EC63.9070600@catalyst.net.nz> Date: Thu, 30 Oct 2014 20:44:35 +1300 From: Mark Kirkwood MIME-Version: 1.0 Subject: Re: fio rbd completions (Was: fio rbd hang for block sizes > 1M) References: <5449BBB3.7090109@catalyst.net.nz> <544E6330.1000202@kernel.dk> <544E63EA.1010204@kernel.dk> <544E6691.106@kernel.dk> <544E6A8D.1040608@kernel.dk> <544EC05D.7040807@catalyst.net.nz> <544EC7F1.6010900@kernel.dk> <544ED37D.6060800@catalyst.net.nz> <79432849-2F58-4738-82E1-E4D8AB10A6AE@kernel.dk> <544FB2F2.2060703@kernel.dk> <544FCDBD.7070106@kernel.dk> <5450FA47.2030203@kernel.dk> In-Reply-To: <5450FA47.2030203@kernel.dk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To: Jens Axboe , Ketor D Cc: Mark Nelson , Mark Nelson , "fio@vger.kernel.org" , "xan.peng" , "ceph-devel@vger.kernel.org" List-ID: On 30/10/14 03:31, Jens Axboe wrote: > On 2014-10-29 01:15, Ketor D wrote: >> Hi, Jens, >> >> There is cmdline parse bug in the fio rbd test. >> >> I have fixed this and create a pull request on the github. >> >> Please review. >> >> After fix the bugs, the fio test can run. > > I merged your two pull requests (thanks!) and committed a polished > variant of the sort patch. Ketor and Mark, would you mind both running a > quick benchmark on the current -git head? > Better late than never (sorry), comparing with the 'original' fio code containing the usleep(100): blocksize k | head iops | orig iops ------------+---------------+-------------- 4 | 11114 | 11516 128 | 4551 | 6550 1024 | 1195 | 1248 So we do pretty much the same except in the middle blocksize range (I checked again with the old binary just to rule out any other changes on the ceph end...). Regards Mark