All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL
Date: Thu, 30 Oct 2014 09:20:13 +0100	[thread overview]
Message-ID: <5451F4BD.4030306@mind.be> (raw)
In-Reply-To: <4f23aeb270143c08f76b81f8ff30c76ea8407a4b.1414589620.git.baruch@tkos.co.il>

On 29/10/14 14:33, Baruch Siach wrote:
> Also remove the comment attributing threads dependency to alsa-lib, since
> shairport-sync itself uses pthreads.
> 
> Fixes:
> http://autobuild.buildroot.net/results/58e/58eafd2499919a45bfb5a2becc233d3678deedde/
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 Regards,
 Arnout

> ---
>  package/shairport-sync/Config.in | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/package/shairport-sync/Config.in b/package/shairport-sync/Config.in
> index ce3106186fb3..c1d81a7e2a54 100644
> --- a/package/shairport-sync/Config.in
> +++ b/package/shairport-sync/Config.in
> @@ -1,7 +1,7 @@
>  config BR2_PACKAGE_SHAIRPORT_SYNC
>  	bool "shairport-sync"
>  	depends on BR2_USE_MMU # libdaemon
> -	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa_lib
> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL
>  	select BR2_PACKAGE_ALSA_LIB
>  	select BR2_PACKAGE_ALSA_LIB_MIXER
>  	select BR2_PACKAGE_LIBDAEMON
> @@ -33,6 +33,6 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_LIBSOXR
>  
>  endif
>  
> -comment "shairport-sync needs a toolchain w/ threads"
> +comment "shairport-sync needs a toolchain w/ NPTL"
>  	depends on BR2_USE_MMU
> -	depends on !BR2_TOOLCHAIN_HAS_THREADS
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2014-10-30  8:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 13:33 [Buildroot] [PATCH] shairport-sync: needs toolchain with NPTL Baruch Siach
2014-10-30  8:20 ` Arnout Vandecappelle [this message]
2014-10-30 20:52 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5451F4BD.4030306@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.