From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 30 Oct 2014 10:54:12 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:55281 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27012245AbaJ3JyLhATRp (ORCPT ); Thu, 30 Oct 2014 10:54:11 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 6F79869862C75; Thu, 30 Oct 2014 09:54:03 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 30 Oct 2014 09:54:04 +0000 Received: from [192.168.154.149] (192.168.154.149) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 30 Oct 2014 09:54:04 +0000 Message-ID: <54520ABC.3040305@imgtec.com> Date: Thu, 30 Oct 2014 09:54:04 +0000 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: James Hogan , Leonid Yegoshin , , , , , , , , , Subject: Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems References: <20141030014753.13189.48344.stgit@linux-yegoshin> <54520969.8030900@imgtec.com> <54520A2D.5080304@imgtec.com> In-Reply-To: <54520A2D.5080304@imgtec.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.149] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43766 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/30/2014 09:51 AM, James Hogan wrote: > Hi Markos, > > On 30/10/14 09:48, Markos Chandras wrote: >>> diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> index f9f4486..fe0b465 100644 >>> --- a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> +++ b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> @@ -52,7 +52,7 @@ static inline int plat_dma_supported(struct device *dev, u64 mask) >>> return 0; >>> } >>> >>> -static inline int plat_device_is_coherent(struct device *dev) >>> +static inline int plat_device_is_coherent(const struct device *dev) >> >> Why adding const here? >> > > > >> Is it just a matter of consistence with the rest of the interfaces? Do >> you need to move these into a separate patch since they don't quite fit >> here. > > See the new new call to plat_device_is_coherent(), which passes dev, > which is const. > > Cheers > James > Ah yes you are right. Thanks! -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:55281 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27012245AbaJ3JyLhATRp (ORCPT ); Thu, 30 Oct 2014 10:54:11 +0100 Message-ID: <54520ABC.3040305@imgtec.com> Date: Thu, 30 Oct 2014 09:54:04 +0000 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems References: <20141030014753.13189.48344.stgit@linux-yegoshin> <54520969.8030900@imgtec.com> <54520A2D.5080304@imgtec.com> In-Reply-To: <54520A2D.5080304@imgtec.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: James Hogan , Leonid Yegoshin , linux-mips@linux-mips.org, nbd@openwrt.org, yanh@lemote.com, linux-kernel@vger.kernel.org, ralf@linux-mips.org, alex.smith@imgtec.com, taohl@lemote.com, chenhc@lemote.com, blogic@openwrt.org Message-ID: <20141030095404.ZL8KtoSG5NL5qCzT7WULKA-Etp6oDSHDEOneHA7-meU@z> On 10/30/2014 09:51 AM, James Hogan wrote: > Hi Markos, > > On 30/10/14 09:48, Markos Chandras wrote: >>> diff --git a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> index f9f4486..fe0b465 100644 >>> --- a/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> +++ b/arch/mips/include/asm/mach-cavium-octeon/dma-coherence.h >>> @@ -52,7 +52,7 @@ static inline int plat_dma_supported(struct device *dev, u64 mask) >>> return 0; >>> } >>> >>> -static inline int plat_device_is_coherent(struct device *dev) >>> +static inline int plat_device_is_coherent(const struct device *dev) >> >> Why adding const here? >> > > > >> Is it just a matter of consistence with the rest of the interfaces? Do >> you need to move these into a separate patch since they don't quite fit >> here. > > See the new new call to plat_device_is_coherent(), which passes dev, > which is const. > > Cheers > James > Ah yes you are right. Thanks! -- markos