From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 30 Oct 2014 11:07:40 +0100 (CET) Received: from mailapp01.imgtec.com ([195.59.15.196]:23962 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011905AbaJ3KHjaGgYz (ORCPT ); Thu, 30 Oct 2014 11:07:39 +0100 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 531B5BE3AB7E1; Thu, 30 Oct 2014 10:07:30 +0000 (GMT) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 30 Oct 2014 10:07:32 +0000 Received: from [192.168.154.101] (192.168.154.101) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 30 Oct 2014 10:07:31 +0000 Message-ID: <54520DE4.9090008@imgtec.com> Date: Thu, 30 Oct 2014 10:07:32 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.8.0 MIME-Version: 1.0 To: Leonid Yegoshin , , , , , , , , , Subject: Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems References: <20141030014753.13189.48344.stgit@linux-yegoshin> In-Reply-To: <20141030014753.13189.48344.stgit@linux-yegoshin> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.101] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43768 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Leonid, On 30/10/14 01:48, Leonid Yegoshin wrote: > A default dma_alloc_coherent() fails to alloc a coherent memory on non-coherent > systems in case of device->coherent_dma_mask covering the whole memory space. > > In case of non-coherent systems the coherent memory on MIPS is restricted by > size of un-cachable segment and should be located in ZONE_DMA. Has this pretty much always been broken? > @@ -81,6 +81,11 @@ static gfp_t massage_gfp_flags(const struct device *dev, gfp_t gfp) > dma_flag = __GFP_DMA; > else > #endif > +#ifdef CONFIG_ZONE_DMA > + if (coherent && !plat_device_is_coherent(dev)) Broken indentation. Please fix to use tabs. > + dma_flag = __GFP_DMA; > + else > +#endif > #if defined(CONFIG_ZONE_DMA32) && defined(CONFIG_ZONE_DMA) > if (dev->coherent_dma_mask < DMA_BIT_MASK(32)) > dma_flag = __GFP_DMA; Other than that, this patch looks okay to me (but those with more experience with MIPS DMA than me may know better). Reviewed-by: James Hogan Thanks James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:23962 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011905AbaJ3KHjaGgYz (ORCPT ); Thu, 30 Oct 2014 11:07:39 +0100 Message-ID: <54520DE4.9090008@imgtec.com> Date: Thu, 30 Oct 2014 10:07:32 +0000 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: DMA: fix coherent alloc in non-coherent systems References: <20141030014753.13189.48344.stgit@linux-yegoshin> In-Reply-To: <20141030014753.13189.48344.stgit@linux-yegoshin> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Leonid Yegoshin , linux-mips@linux-mips.org, nbd@openwrt.org, yanh@lemote.com, linux-kernel@vger.kernel.org, ralf@linux-mips.org, alex.smith@imgtec.com, taohl@lemote.com, chenhc@lemote.com, blogic@openwrt.org Message-ID: <20141030100732.COxH0vuaPaN17hBcLPdptsGdTMMUkdqmFhDoD2UOGPU@z> Hi Leonid, On 30/10/14 01:48, Leonid Yegoshin wrote: > A default dma_alloc_coherent() fails to alloc a coherent memory on non-coherent > systems in case of device->coherent_dma_mask covering the whole memory space. > > In case of non-coherent systems the coherent memory on MIPS is restricted by > size of un-cachable segment and should be located in ZONE_DMA. Has this pretty much always been broken? > @@ -81,6 +81,11 @@ static gfp_t massage_gfp_flags(const struct device *dev, gfp_t gfp) > dma_flag = __GFP_DMA; > else > #endif > +#ifdef CONFIG_ZONE_DMA > + if (coherent && !plat_device_is_coherent(dev)) Broken indentation. Please fix to use tabs. > + dma_flag = __GFP_DMA; > + else > +#endif > #if defined(CONFIG_ZONE_DMA32) && defined(CONFIG_ZONE_DMA) > if (dev->coherent_dma_mask < DMA_BIT_MASK(32)) > dma_flag = __GFP_DMA; Other than that, this patch looks okay to me (but those with more experience with MIPS DMA than me may know better). Reviewed-by: James Hogan Thanks James