From: Adrian Hunter <adrian.hunter@intel.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Chris Ball <chris@printf.net>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 00/15] mmc: sdhci: Add 64-bit ADMA support
Date: Thu, 30 Oct 2014 12:50:59 +0200 [thread overview]
Message-ID: <54521813.9050308@intel.com> (raw)
In-Reply-To: <7275405.tTXMrp5n17@wuerfel>
On 30/10/14 12:00, Arnd Bergmann wrote:
> On Thursday 30 October 2014 10:40:12 Adrian Hunter wrote:
>> On 30/10/14 10:05, Arnd Bergmann wrote:
>>> On Thursday 30 October 2014 09:25:54 Adrian Hunter wrote:
>>>> On 21/10/14 12:26, Adrian Hunter wrote:
>>>>> Hi
>>>>>
>>>>> Here are patches to add 64-bit ADMA support to the SDHCI driver.
>>>>>
>>>>> The patchset starts with 3 minor fixes related to SDHCI ADMA,
>>>>> then there are 8 preparatory patches, then 3 main patches, then
>>>>> the mmc_test "Badly aligned" tests are extended slightly.
>>>>
>>>> Hi Ulf
>>>>
>>>> Can you take these? Note that there was a V2 of
>>>> "mmc: sdhci-acpi: Add 64-bit DMA support". Also
>>>> that patch is dependent (for functionality not
>>>> compilation) on a patch in v3.18-rc2 so it is slightly
>>>> preferable if you pull v3.18-rc2 first.
>>>
>>> You still haven't addressed my comments about clearing
>>> the SDHCI_USE_64_BIT_DMA flag if the platform finds that
>>> hardware has set this bit incorrectly.
>>
>> Yes I did. I said there was no need:
>>
>> http://marc.info/?l=linux-mmc&m=141449082331402&w=2
>>
>> I would also note that the SDHCI spec does not say explicitly
>> that a 64-bit device supports 32-bit DMA descriptors.
>>
>> If the hardware really is broken, the SDHCI_QUIRK2_BROKEN_64_BIT_DMA
>> should be used.
>
> You also said that the flag is defined to mean that 64-bit DMA
> is working and that you want to show the warning when the hardware
> and the firmware disagree about this. If you have an (at least)
> 50% chance that the hardware is lying, you really shouldn't believe
> it.
Just because there are two options does not mean they are each equally
likely.
next prev parent reply other threads:[~2014-10-30 10:52 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 9:26 [PATCH 00/15] mmc: sdhci: Add 64-bit ADMA support Adrian Hunter
2014-10-21 9:26 ` [PATCH 01/15] mmc: sdhci: Fix incorrect ADMA2 descriptor table size Adrian Hunter
2014-10-21 9:26 ` [PATCH 02/15] mmc: sdhci: Fix ADMA page boundary warnings Adrian Hunter
2014-10-21 9:26 ` [PATCH 03/15] mmc: sdhci: Fix ADMA table size warning Adrian Hunter
2014-10-21 9:26 ` [PATCH 04/15] mmc: sdhci: Rename two ADMA-related functions for consistency Adrian Hunter
2014-10-21 9:26 ` [PATCH 05/15] mmc: sdhci: Rename adma_desc to adma_table Adrian Hunter
2014-10-21 9:26 ` [PATCH 06/15] mmc: sdhci: Add sdhci_adma_mark_end() Adrian Hunter
2014-10-21 9:26 ` [PATCH 07/15] mmc: sdhci: Use 'void *' for not 'u8 *' for ADMA data Adrian Hunter
2014-10-21 9:26 ` [PATCH 08/15] mmc: sdhci: Parameterize ADMA sizes and alignment Adrian Hunter
2014-10-21 9:26 ` [PATCH 09/15] mmc: sdhci: Define maximum segments Adrian Hunter
2014-10-21 9:26 ` [PATCH 10/15] mmc: sdhci: Define ADMA constants Adrian Hunter
2014-10-21 9:26 ` [PATCH 11/15] mmc: sdhci: Define ADMA descriptor structure Adrian Hunter
2014-10-21 9:26 ` [PATCH 12/15] mmc: sdhci: Add 64-bit ADMA support Adrian Hunter
2014-10-21 9:26 ` [PATCH 13/15] mmc: sdhci-acpi: Add 64-bit DMA support Adrian Hunter
2014-10-21 9:33 ` Arnd Bergmann
2014-10-21 10:45 ` Adrian Hunter
2014-10-21 11:05 ` Arnd Bergmann
2014-10-28 8:37 ` [PATCH V2] " Adrian Hunter
2014-10-28 9:43 ` Arnd Bergmann
2014-10-28 10:05 ` Adrian Hunter
2014-10-28 10:18 ` Arnd Bergmann
2014-10-28 11:41 ` Adrian Hunter
2014-10-28 13:54 ` Arnd Bergmann
2014-10-28 14:14 ` Adrian Hunter
2014-10-28 15:08 ` Arnd Bergmann
2014-10-28 15:14 ` Adrian Hunter
2014-10-28 15:38 ` Arnd Bergmann
2014-10-29 8:53 ` Adrian Hunter
2014-10-21 9:26 ` [PATCH 14/15] mmc: sdhci-pci: " Adrian Hunter
2014-10-21 9:26 ` [PATCH 15/15] mmc: mmc_test: Extend "Badly aligned" tests for 8-byte alignment Adrian Hunter
2014-10-30 7:25 ` [PATCH 00/15] mmc: sdhci: Add 64-bit ADMA support Adrian Hunter
2014-10-30 8:05 ` Arnd Bergmann
2014-10-30 8:40 ` Adrian Hunter
2014-10-30 10:00 ` Arnd Bergmann
2014-10-30 10:50 ` Adrian Hunter [this message]
2014-10-30 12:15 ` Arnd Bergmann
2014-10-30 12:55 ` Adrian Hunter
2014-11-03 8:28 ` Adrian Hunter
2014-11-03 14:40 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54521813.9050308@intel.com \
--to=adrian.hunter@intel.com \
--cc=arnd@arndb.de \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.