From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [RFC 1/2] PM / Domains: Power on domain early during system resume Date: Thu, 30 Oct 2014 12:01:35 +0100 Message-ID: <54521A8F.5070808@samsung.com> References: <1414072090-11293-1-git-send-email-k.kozlowski@samsung.com> <1414072090-11293-2-git-send-email-k.kozlowski@samsung.com> <7hk33iahvu.fsf@deeprootsystems.com> <1414654594.5114.8.camel@AMDC1943> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1414654594.5114.8.camel@AMDC1943> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Krzysztof Kozlowski , Kevin Hilman Cc: Len Brown , Kukjin Kim , linux-pm@vger.kernel.org, Greg Kroah-Hartman , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Seung-Woo Kim , Kyungmin Park , linux-samsung-soc@vger.kernel.org, Pavel Machek , linux-arm-kernel@lists.infradead.org, Marek Szyprowski List-Id: linux-pm@vger.kernel.org T24gMTAvMzAvMjAxNCAwODozNiBBTSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiBPbiDF m3JvLCAyMDE0LTEwLTI5IGF0IDEwOjQ2IC0wNzAwLCBLZXZpbiBIaWxtYW4gd3JvdGU6Cj4+IEty enlzenRvZiBLb3psb3dza2kgPGsua296bG93c2tpQHNhbXN1bmcuY29tPiB3cml0ZXM6Cj4+Cj4+ PiBXaGVuIHJlc3VtaW5nIHRoZSBzeXN0ZW0gdGhlIHBvd2VyIGRvbWFpbiBoYXMgdG8gYmUgcG93 ZXJlZCBvbiBlYXJseSBzbwo+Pj4gYW55IHJ1bnRpbWUgUE0gYXdhcmUgZGV2aWNlcyBjb3VsZCBy ZXN1bWUuCj4+Pgo+Pj4gVGhpcyBmaXhlcyBmb2xsb3dpbmcgc2NlbmFyaW8gcmVwcm9kdWNlZCBv biBFeHlub3MgRFJNOgo+Pj4gMS4gUG93ZXIgZG9tYWluIGlzIG9mZiBiZWZvcmUgc3VzcGVuZGlu ZyB0aGUgc3lzdGVtLgo+Pj4gMi4gU3lzdGVtIGlzIHN1c3BlbmRlZCB0byBSQU0uCj4+PiAzLiBS ZXN1bWluZyBzdGFydHMuIFRoZSBFeHlub3MgRFJNIGRyaXZlciByZXN1bWUgY2FsbGJhY2sgaXMg Y2FsbGVkLgo+Pj4gNC4gVGhlIEV4eW5vcyBEUk0gZHJpdmVyIGNhbGxzIGRybV9oZWxwZXJfcmVz dW1lX2ZvcmNlX21vZGUgd2hpY2ggdHVybnMKPj4+ICAgIHRoZSBzY3JlZW4gb24gYnkgY2FsbGlu ZyBleHlub3NfZHNpX2RwbXMgd2l0aCBEUk1fTU9ERV9EUE1TX09OLgo+PiBEdW1iIFE6IGlmIHRo ZSBkZXZpY2UgKGFuZCBwb3dlciBkb21haW4pIHdlcmUgb2ZmIGJlZm9yZSAoYW5kIGR1cmluZykK Pj4gc3VzcGVuZCwgd2h5IGFyZSB0aGV5IGJlaW5nIHJlc3VtZWQ/Cj4+Cj4+IFNob3VsZG4ndCB0 aGUgcmVzdW1lIHBhdGggcmVzdG9yZSB0aGluZ3MgdG8gdGhlIHNhbWUgc3RhdGUgdGhleSB3ZXJl Cj4+IGJlZm9yZSBzdXNwZW5kPwo+IE9uZSBjb3VsZCBleHBlY3QgdGhhdC4uLiBidXQgdGhlIEV4 eW5vcyBEUk0gZHJpdmVyIGJlaGF2ZXMgZGlmZmVyZW50bHkKPiAoYW5kIHNvbWUgb3RoZXIgZHJp dmVycyBhbHNvKS4gSW4gcmVzdW1lIG1ldGhvZCBpdCBjYWxscwo+IGRybV9oZWxwZXJfcmVzdW1l X2ZvcmNlX21vZGUoKSB3aGljaCBmb3JjZXMgcmVzdG9yaW5nIG1vZGUgc2V0dGluZwo+IGNvbmZp Z3VyYXRpb24uIEFwcGFyZW50bHkgc2V0dGluZyBhIG1vZGUgbmVlZHMgRFBNUyBvbjoKPiBzdGF0 aWMgdm9pZCBleHlub3NfZHJtX2NydGNfY29tbWl0KHN0cnVjdCBkcm1fY3J0YyAqY3J0YykKPiB7 Cj4gCS4uLgo+IAlleHlub3NfZHJtX2NydGNfZHBtcyhjcnRjLCBEUk1fTU9ERV9EUE1TX09OKTsK PiAJLi4uCj4KPiBUaGUgcHJldmlvdXMgRFBNUyBzdGF0dXMgKHN0YXR1cyBkdXJpbmcgc3VzcGVu ZCkgaXMgY29tcGxldGVseSBpZ25vcmVkCj4gaGVyZS4KClN1c3BlbmQgY2FsbGJhY2sgc3dpdGNo ZXMgb2ZmIGFsbCBjb25uZWN0b3JzICh0aHVzIGFsbCBvdGhlciBkZXZzIGluCnRoZWlyIHBpcGVs aW5lKSBieSBjYWxsaW5nIGRwbXNfb2ZmLAppbiByZXN0b3JlIGNhbGxiYWNrIGFsbCBkZXZzIGFy ZSByZXN0b3JlZCB0byB0aGVpciBwcmV2aW91cyBzdGF0ZSBieQpjYWxsaW5nIGFwcHJvcHJpYXRl IGRwbXMuClNvIEkgZ3Vlc3MgZHJtX2hlbHBlcl9yZXN1bWVfZm9yY2VfbW9kZSgpIGNhbGwgYXQg dGhlIGVuZCBvZiByZXN1bWUgaXMKaW5jb3JyZWN0LgpPbiB0aGUgb3RoZXIgc2lkZSBpdCBpcyBw cmVzZW50IGluIG1hbnkgb3RoZXIgZHJpdmVycywgc28gSSBhbSBhbHNvCmxpdHRsZSBiaXQgY29u ZnVzZWQuCgpSZWdhcmRzCkFuZHJ6ZWoKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: a.hajda@samsung.com (Andrzej Hajda) Date: Thu, 30 Oct 2014 12:01:35 +0100 Subject: [RFC 1/2] PM / Domains: Power on domain early during system resume In-Reply-To: <1414654594.5114.8.camel@AMDC1943> References: <1414072090-11293-1-git-send-email-k.kozlowski@samsung.com> <1414072090-11293-2-git-send-email-k.kozlowski@samsung.com> <7hk33iahvu.fsf@deeprootsystems.com> <1414654594.5114.8.camel@AMDC1943> Message-ID: <54521A8F.5070808@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/30/2014 08:36 AM, Krzysztof Kozlowski wrote: > On ?ro, 2014-10-29 at 10:46 -0700, Kevin Hilman wrote: >> Krzysztof Kozlowski writes: >> >>> When resuming the system the power domain has to be powered on early so >>> any runtime PM aware devices could resume. >>> >>> This fixes following scenario reproduced on Exynos DRM: >>> 1. Power domain is off before suspending the system. >>> 2. System is suspended to RAM. >>> 3. Resuming starts. The Exynos DRM driver resume callback is called. >>> 4. The Exynos DRM driver calls drm_helper_resume_force_mode which turns >>> the screen on by calling exynos_dsi_dpms with DRM_MODE_DPMS_ON. >> Dumb Q: if the device (and power domain) were off before (and during) >> suspend, why are they being resumed? >> >> Shouldn't the resume path restore things to the same state they were >> before suspend? > One could expect that... but the Exynos DRM driver behaves differently > (and some other drivers also). In resume method it calls > drm_helper_resume_force_mode() which forces restoring mode setting > configuration. Apparently setting a mode needs DPMS on: > static void exynos_drm_crtc_commit(struct drm_crtc *crtc) > { > ... > exynos_drm_crtc_dpms(crtc, DRM_MODE_DPMS_ON); > ... > > The previous DPMS status (status during suspend) is completely ignored > here. Suspend callback switches off all connectors (thus all other devs in their pipeline) by calling dpms_off, in restore callback all devs are restored to their previous state by calling appropriate dpms. So I guess drm_helper_resume_force_mode() call at the end of resume is incorrect. On the other side it is present in many other drivers, so I am also little bit confused. Regards Andrzej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933021AbaJ3LBn (ORCPT ); Thu, 30 Oct 2014 07:01:43 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:22356 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932649AbaJ3LBl (ORCPT ); Thu, 30 Oct 2014 07:01:41 -0400 MIME-version: 1.0 Content-type: text/plain; charset=utf-8 X-AuditID: cbfec7f5-b7f956d000005ed7-88-54521a936c3a Content-transfer-encoding: 8BIT Message-id: <54521A8F.5070808@samsung.com> Date: Thu, 30 Oct 2014 12:01:35 +0100 From: Andrzej Hajda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 To: Krzysztof Kozlowski , Kevin Hilman Cc: "Rafael J. Wysocki" , Pavel Machek , Len Brown , Greg Kroah-Hartman , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , David Airlie , Kukjin Kim , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, Marek Szyprowski , Bartlomiej Zolnierkiewicz Subject: Re: [RFC 1/2] PM / Domains: Power on domain early during system resume References: <1414072090-11293-1-git-send-email-k.kozlowski@samsung.com> <1414072090-11293-2-git-send-email-k.kozlowski@samsung.com> <7hk33iahvu.fsf@deeprootsystems.com> <1414654594.5114.8.camel@AMDC1943> In-reply-to: <1414654594.5114.8.camel@AMDC1943> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42I5/e/4Nd3JUkEhBlO28Vn0njvJZLFxxnpW iytf37NZNC9ez2Yx6f4EFosX9y6yWLx+YWjRu+Aqm8XTzY+ZLM42vWG3mDVlL5PFpsfXWC0u 75rDZvG59wijxYzz+5gs1h65y25x99RRNoszpy+xWsyY/JLNQdhj8Z6XTB6bVnWyeWz/9oDV Y//cNewe97uPM3lsXlLvseVqO4tH35ZVjB4rVn9n9/i8SS6AK4rLJiU1J7MstUjfLoEr48rL 9YwFX3grfk76xtTAuJa7i5GTQ0LAROL7xNeMELaYxIV769m6GLk4hASWMkq0fnnJBJLgFRCU +DH5HksXIwcHs4C8xJFL2RCmusSUKbkQ5Z8YJR7uewFVriVx52wXmM0ioCrxfeoJMJtNQFPi 7+abbCC2qECExJU1c8D2igiESez6vZQFZBCzwDRWiZmv/7ODJIQF/CU+3brHCLHhPKPEhDOH wbo5BfQldn9+zzKBUWAWkvtmIdw3C+G+BYzMqxhFU0uTC4qT0nON9IoTc4tL89L1kvNzNzFC IvHrDsalx6wOMQpwMCrx8EYcCwgRYk0sK67MPcQowcGsJMK7WiwoRIg3JbGyKrUoP76oNCe1 +BAjEwenVAOj8cZXQvfcJyTP2MDv1na9iIe1x2Om2Fn3IoN37fFsFRsfhh56ffNS0ZlQuxLv ZxsnLglcV/zN6eHJeZFhJ74Hh0c8DH95kl3ybYdk8jzB27dVXh0K+RFzQKMn5M/xeca7tG58 Ovm8zKFBuPdf+8176y8XvE/K+Gp6uUhvhmPGDMuYqC2qFvOElFiKMxINtZiLihMB2DSBtKIC AAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/30/2014 08:36 AM, Krzysztof Kozlowski wrote: > On śro, 2014-10-29 at 10:46 -0700, Kevin Hilman wrote: >> Krzysztof Kozlowski writes: >> >>> When resuming the system the power domain has to be powered on early so >>> any runtime PM aware devices could resume. >>> >>> This fixes following scenario reproduced on Exynos DRM: >>> 1. Power domain is off before suspending the system. >>> 2. System is suspended to RAM. >>> 3. Resuming starts. The Exynos DRM driver resume callback is called. >>> 4. The Exynos DRM driver calls drm_helper_resume_force_mode which turns >>> the screen on by calling exynos_dsi_dpms with DRM_MODE_DPMS_ON. >> Dumb Q: if the device (and power domain) were off before (and during) >> suspend, why are they being resumed? >> >> Shouldn't the resume path restore things to the same state they were >> before suspend? > One could expect that... but the Exynos DRM driver behaves differently > (and some other drivers also). In resume method it calls > drm_helper_resume_force_mode() which forces restoring mode setting > configuration. Apparently setting a mode needs DPMS on: > static void exynos_drm_crtc_commit(struct drm_crtc *crtc) > { > ... > exynos_drm_crtc_dpms(crtc, DRM_MODE_DPMS_ON); > ... > > The previous DPMS status (status during suspend) is completely ignored > here. Suspend callback switches off all connectors (thus all other devs in their pipeline) by calling dpms_off, in restore callback all devs are restored to their previous state by calling appropriate dpms. So I guess drm_helper_resume_force_mode() call at the end of resume is incorrect. On the other side it is present in many other drivers, so I am also little bit confused. Regards Andrzej