From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrzej Hajda Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable Date: Thu, 30 Oct 2014 13:39:40 +0100 Message-ID: <5452318C.1030107@samsung.com> References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Inki Dae Cc: Kukjin Kim , Seung-Woo Kim , open list , "open list:DRM DRIVERS FOR E..." , Kyungmin Park , "moderated list:ARM/S5P EXYNOS AR..." , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMTAvMDcvMjAxNCAwMjowMSBQTSwgQW5kcnplaiBIYWpkYSB3cm90ZToKPiBIaSBJbmtpLAo+ Cj4gTWFueSBFeHlub3MgRFJNIGRyaXZlcnMgdXNlcyBnbG9iYWwgdmFyaWFibGVzIHRvIHJlcHJl c2VudCBhc3NvY2lhdGVkIGRldmljZXMKPiBpbiBFeHlub3MgRFJNIGludGVybmFsIGZyYW1ld29y ay4gSXQgaXMgcXVpdGUgY29uZnVzaW5nLCBpdCBhZGRzIGRhdGEgZHVwbGljYXRpb24KPiBhbmQg ZmluYWxseSBpdCBkb2VzIG5vdCBhbGxvdyB0byBoYW5kbGUgbW9yZSB0aGFuIG9uZSBkZXZpY2Ug aW4gc3lzdGVtLgo+IEl0IHNlZW1zIGJldHRlciB0byBlbWJlZCBzdWNoIHN0cnVjdHVyZXMgaW4g cHJpdmF0ZSBjb250ZXh0IG9mIHRoZSBkZXZpY2UuCgpHZW50bHkgcGluZy4KClJlZ2FyZHMKQW5k cnplagoKPgo+IFRoZSBwYXRjaHNldCBpcyBiYXNlZCBvbiBleHlub3NfZHJtX25leHQgcGx1cyBt eSBwYXRjaCBbMV06Cj4gJ2RybS9leHlub3M6IHJlbW92ZSBleHBsaWNpdCBlbmNvZGVyL2Nvbm5l Y3RvciBkZS1pbml0aWFsaXphdGlvbicuCj4KPiBJZiB0aGUgcGF0Y2hzZXQgaXMgT0sgZm9yIHlv dSBJIGNhbiBwcmVwYXJlIHNpbWlsYXIgcGF0Y2hlcyBmb3Igb3RoZXIgRXh5bm9zIERSTSBjb21w b25lbnRzLgo+Cj4gWzFdOiBodHRwczovL2xrbWwub3JnL2xrbWwvMjAxNC85LzIyLzE0OAo+Cj4g UmVnYXJkcwo+IEFuZHJ6ZWoKPgo+Cj4gQW5kcnplaiBIYWpkYSAoNCk6Cj4gICBkcm0vZXh5bm9z L2RzaTogcmVtb3ZlIGdsb2JhbCB2YXJpYWJsZSBleHlub3NfZHNpX2Rpc3BsYXkKPiAgIGRybS9l eHlub3MvZHNpOiBzaW1wbGlmeSBkZXZpY2UgcG9pbnRlciBldmFsdWF0aW9uCj4gICBkcm0vZXh5 bm9zL2RzaTogcmVtb3ZlIHJlZHVuZGFudCBlbmNvZGVyIGZpZWxkCj4gICBkcm0vZXh5bm9zL2Rz aTogc3RvcCB1c2luZyBkaXNwbGF5LT5jdHggcG9pbnRlcgo+Cj4gIGRyaXZlcnMvZ3B1L2RybS9l eHlub3MvZXh5bm9zX2RybV9kc2kuYyB8IDk2ICsrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0p Cj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1k ZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759653AbaJ3Mjr (ORCPT ); Thu, 30 Oct 2014 08:39:47 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:28083 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759060AbaJ3Mjn (ORCPT ); Thu, 30 Oct 2014 08:39:43 -0400 X-AuditID: cbfec7f4-b7f6c6d00000120b-7d-5452318d5b0d Message-id: <5452318C.1030107@samsung.com> Date: Thu, 30 Oct 2014 13:39:40 +0100 From: Andrzej Hajda User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-version: 1.0 To: Inki Dae Cc: Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , "open list:DRM DRIVERS FOR E..." , "moderated list:ARM/S5P EXYNOS AR..." , open list Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> In-reply-to: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFLMWRmVeSWpSXmKPExsVy+t/xy7q9hkEhBi9+KVpc+fqezWLS/Qks Fi/uXWSx6F1wlc3ibNMbdovLu+awWcw4v4/JYu2Ru+wWMya/ZHPg9LjffZzJo2/LKkaPz5vk ApijuGxSUnMyy1KL9O0SuDKOH3zDVPCIo+J/X1ED4wT2LkZODgkBE4nvnW+YIWwxiQv31rOB 2EICSxklji3w7GLkArI/MUp0/TnJ2sXIwcEroCWxZrc5SA2LgKrEj1WPwOrZBDQl/m6+CWaL CkRIXFkzhxHE5hUQlPgx+R4LiC0ioCyxal87O8hMZoGpzBIXFvWAJYQF3CUerV7DArHYWWLy 6a1MIDangIvEvA2v2ED2MgvoSdy/qAUSZhaQl9i85i3zBEaBWUhWzEKomoWkagEj8ypG0dTS 5ILipPRcQ73ixNzi0rx0veT83E2MkPD+soNx8TGrQ4wCHIxKPLwOGwNChFgTy4orcw8xSnAw K4nwHtUJChHiTUmsrEotyo8vKs1JLT7EyMTBKdXAKNFw/fC56t9Wj6wfzb/TcUv7PfsyBgkT fkvuHHE+c67lrzo2MV0U9n/51VFZcGl6w+dOjqt/vXL99M7+vV4Rf0Wq/V2z6cw9n0oW9y71 /Xjk8bl74QIJFpGKtf/97gQuPWRQaMNs3jx5+hbd+ma9hAWLV2u7v1EpvmN8wKTlkce9fT/t 7/66ocRSnJFoqMVcVJwIABeGfT9NAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/07/2014 02:01 PM, Andrzej Hajda wrote: > Hi Inki, > > Many Exynos DRM drivers uses global variables to represent associated devices > in Exynos DRM internal framework. It is quite confusing, it adds data duplication > and finally it does not allow to handle more than one device in system. > It seems better to embed such structures in private context of the device. Gently ping. Regards Andrzej > > The patchset is based on exynos_drm_next plus my patch [1]: > 'drm/exynos: remove explicit encoder/connector de-initialization'. > > If the patchset is OK for you I can prepare similar patches for other Exynos DRM components. > > [1]: https://lkml.org/lkml/2014/9/22/148 > > Regards > Andrzej > > > Andrzej Hajda (4): > drm/exynos/dsi: remove global variable exynos_dsi_display > drm/exynos/dsi: simplify device pointer evaluation > drm/exynos/dsi: remove redundant encoder field > drm/exynos/dsi: stop using display->ctx pointer > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 96 ++++++++++++++++----------------- > 1 file changed, 47 insertions(+), 49 deletions(-) >