From mboxrd@z Thu Jan 1 00:00:00 1970 From: Inki Dae Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable Date: Thu, 30 Oct 2014 21:59:59 +0900 Message-ID: <5452364F.2070402@samsung.com> References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> <5452318C.1030107@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-reply-to: <5452318C.1030107@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Andrzej Hajda Cc: Kukjin Kim , Seung-Woo Kim , open list , "open list:DRM DRIVERS FOR E..." , Kyungmin Park , "moderated list:ARM/S5P EXYNOS AR..." , Marek Szyprowski List-Id: linux-samsung-soc@vger.kernel.org T24gMjAxNOuFhCAxMOyblCAzMOydvCAyMTozOSwgQW5kcnplaiBIYWpkYSB3cm90ZToKPiBPbiAx MC8wNy8yMDE0IDAyOjAxIFBNLCBBbmRyemVqIEhhamRhIHdyb3RlOgo+PiBIaSBJbmtpLAo+Pgo+ PiBNYW55IEV4eW5vcyBEUk0gZHJpdmVycyB1c2VzIGdsb2JhbCB2YXJpYWJsZXMgdG8gcmVwcmVz ZW50IGFzc29jaWF0ZWQgZGV2aWNlcwo+PiBpbiBFeHlub3MgRFJNIGludGVybmFsIGZyYW1ld29y ay4gSXQgaXMgcXVpdGUgY29uZnVzaW5nLCBpdCBhZGRzIGRhdGEgZHVwbGljYXRpb24KPj4gYW5k IGZpbmFsbHkgaXQgZG9lcyBub3QgYWxsb3cgdG8gaGFuZGxlIG1vcmUgdGhhbiBvbmUgZGV2aWNl IGluIHN5c3RlbS4KPj4gSXQgc2VlbXMgYmV0dGVyIHRvIGVtYmVkIHN1Y2ggc3RydWN0dXJlcyBp biBwcml2YXRlIGNvbnRleHQgb2YgdGhlIGRldmljZS4KPiAKPiBHZW50bHkgcGluZy4KClRoaXMg cGF0Y2ggc2VyaWVzIGFscmVhZHkgaXMgaW4gZXh5bm9zLWRybS1uZXh0LXRvZG8gYnJhbmNoLiBJ IHdpbGwgbW92ZQppdCB0byBleHlub3MtZHJtLW5leHQgYWZ0ZXIgY2hlY2tpbmcuCgpUaGFua3Ms Cklua2kgRGFlCgo+IAo+IFJlZ2FyZHMKPiBBbmRyemVqCj4gCj4+Cj4+IFRoZSBwYXRjaHNldCBp cyBiYXNlZCBvbiBleHlub3NfZHJtX25leHQgcGx1cyBteSBwYXRjaCBbMV06Cj4+ICdkcm0vZXh5 bm9zOiByZW1vdmUgZXhwbGljaXQgZW5jb2Rlci9jb25uZWN0b3IgZGUtaW5pdGlhbGl6YXRpb24n Lgo+Pgo+PiBJZiB0aGUgcGF0Y2hzZXQgaXMgT0sgZm9yIHlvdSBJIGNhbiBwcmVwYXJlIHNpbWls YXIgcGF0Y2hlcyBmb3Igb3RoZXIgRXh5bm9zIERSTSBjb21wb25lbnRzLgo+Pgo+PiBbMV06IGh0 dHBzOi8vbGttbC5vcmcvbGttbC8yMDE0LzkvMjIvMTQ4Cj4+Cj4+IFJlZ2FyZHMKPj4gQW5kcnpl ago+Pgo+Pgo+PiBBbmRyemVqIEhhamRhICg0KToKPj4gICBkcm0vZXh5bm9zL2RzaTogcmVtb3Zl IGdsb2JhbCB2YXJpYWJsZSBleHlub3NfZHNpX2Rpc3BsYXkKPj4gICBkcm0vZXh5bm9zL2RzaTog c2ltcGxpZnkgZGV2aWNlIHBvaW50ZXIgZXZhbHVhdGlvbgo+PiAgIGRybS9leHlub3MvZHNpOiBy ZW1vdmUgcmVkdW5kYW50IGVuY29kZXIgZmllbGQKPj4gICBkcm0vZXh5bm9zL2RzaTogc3RvcCB1 c2luZyBkaXNwbGF5LT5jdHggcG9pbnRlcgo+Pgo+PiAgZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9l eHlub3NfZHJtX2RzaS5jIHwgOTYgKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCj4+ ICAxIGZpbGUgY2hhbmdlZCwgNDcgaW5zZXJ0aW9ucygrKSwgNDkgZGVsZXRpb25zKC0pCj4+Cj4g Cj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmkt ZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759605AbaJ3NAE (ORCPT ); Thu, 30 Oct 2014 09:00:04 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:40019 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbaJ3NAB (ORCPT ); Thu, 30 Oct 2014 09:00:01 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79b46d000002b74-38-5452364fbd7e Content-transfer-encoding: 8BIT Message-id: <5452364F.2070402@samsung.com> Date: Thu, 30 Oct 2014 21:59:59 +0900 From: Inki Dae User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130803 Thunderbird/17.0.8 To: Andrzej Hajda Cc: Marek Szyprowski , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Kukjin Kim , "open list:DRM DRIVERS FOR E..." , "moderated list:ARM/S5P EXYNOS AR..." , open list Subject: Re: [PATCH 0/4] drm/exynos/dsi: remove global display variable References: <1412683271-15835-1-git-send-email-a.hajda@samsung.com> <5452318C.1030107@samsung.com> In-reply-to: <5452318C.1030107@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWyRsSkUNffLCjE4P4kKYtb686xWlz5+p7N 4sW9iywWvQuuslmcbXrDbnF51xw2ixnn9zFZrD1yl91ixuSXbA6cHve7jzN59G1ZxejxeZNc AHMUl01Kak5mWWqRvl0CV8aaJS9ZCy5yVZw7toSlgfEMRxcjJ4eEgIlEz69+VghbTOLCvfVs XYxcHEICSxklXhzewghT9HLnHnaIxCJGid03fjGBJHgFBCV+TL7H0sXIwcEsIC9x5FI2SJhZ QF1i0rxFzCC2kMArRolFXRIQ5VoSx/99ZgexWQRUJRa+OMwGYrMB2RNX3AezRQXCJF682gXW KwI0Z/bJO8wge5kFpjJLXFjUwwKSEBZwl3i0eg0LxIIUiderfrGB3MApoC3R+JQDpF5C4BK7 RM+EVcwQywQkvk0+BHanhICsxKYDzBB/SUocXHGDZQKj2Cwk38xC+GYWkm8WMDKvYhRNLUgu KE5KLzLSK07MLS7NS9dLzs/dxAiMudP/nvXtYLx5wPoQowAHoxIPr8aJwBAh1sSy4srcQ4ym QEdMZJYSTc4HRnZeSbyhsZmRhamJqbGRuaWZkjhvgtTPYCGB9MSS1OzU1ILUovii0pzU4kOM TBycUg2MYRG6rBdZNtw59CN5J+8y3+OR1zMN++VM5O7JKrLzBpyYfErSoGjBdvn5bacfvfT7 nqJW/NxZ7PFcFotlet37ctdwr3ZcWOF1uj/qwwfBi9mWK5qD0pYuOsa2dtNS9y+PHqrqOu6W n3+TZS3ThKmXv3Kr7/x4d9XsF5z3YzwkL/9a92HxbfHrNUosxRmJhlrMRcWJAHyW3e+0AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNIsWRmVeSWpSXmKPExsVy+t9jAV1/s6AQg+sThSxurTvHanHl63s2 ixf3LrJY9C64ymZxtukNu8XlXXPYLGac38dksfbIXXaLGZNfsjlwetzvPs7k0bdlFaPH501y AcxRDYw2GamJKalFCql5yfkpmXnptkrewfHO8aZmBoa6hpYW5koKeYm5qbZKLj4Bum6ZOUB3 KCmUJeaUAoUCEouLlfTtME0IDXHTtYBpjND1DQmC6zEyQAMJaxgz1ix5yVpwkavi3LElLA2M Zzi6GDk5JARMJF7u3MMOYYtJXLi3nq2LkYtDSGARo8TuG7+YQBK8AoISPybfY+li5OBgFpCX OHIpGyTMLKAuMWneImYQW0jgFaPEoi4JiHItieP/PoPNZBFQlVj44jAbiM0GZE9ccR/MFhUI k3jxahdYrwjQnNkn7zCD7GUWmMoscWFRDwtIQljAXeLR6jUsEAtSJF6v+sUGcgOngLZE41OO CYwCs5BcNwvhullIrlvAyLyKUTS1ILmgOCk910ivODG3uDQvXS85P3cTIziin0nvYFzVYHGI UYCDUYmHV+NEYIgQa2JZcWXuIUYJDmYlEd6jOkEhQrwpiZVVqUX58UWlOanFhxhNgZ6byCwl mpwPTDZ5JfGGxiZmRpZG5oYWRsbmSuK8B1utA4UE0hNLUrNTUwtSi2D6mDg4pRoYPR7+YPUv fW5jNFUv+FqHRPZODdey+eH7vvzoy828Wdly8s4fg+f96jcfT7kdGcts9NBHaXqXwh/fPZsU GVfbtIUGzfp2rmCJ0YMP01dmTZD5yeiy9GKC2IGQvil6uamvOtqYzjw0/xaYPmv23xdRVgyq J5/YZJyKCDt0R//SU4vJD/c/1tT3V2Ipzkg01GIuKk4EACRbPRT+AgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014년 10월 30일 21:39, Andrzej Hajda wrote: > On 10/07/2014 02:01 PM, Andrzej Hajda wrote: >> Hi Inki, >> >> Many Exynos DRM drivers uses global variables to represent associated devices >> in Exynos DRM internal framework. It is quite confusing, it adds data duplication >> and finally it does not allow to handle more than one device in system. >> It seems better to embed such structures in private context of the device. > > Gently ping. This patch series already is in exynos-drm-next-todo branch. I will move it to exynos-drm-next after checking. Thanks, Inki Dae > > Regards > Andrzej > >> >> The patchset is based on exynos_drm_next plus my patch [1]: >> 'drm/exynos: remove explicit encoder/connector de-initialization'. >> >> If the patchset is OK for you I can prepare similar patches for other Exynos DRM components. >> >> [1]: https://lkml.org/lkml/2014/9/22/148 >> >> Regards >> Andrzej >> >> >> Andrzej Hajda (4): >> drm/exynos/dsi: remove global variable exynos_dsi_display >> drm/exynos/dsi: simplify device pointer evaluation >> drm/exynos/dsi: remove redundant encoder field >> drm/exynos/dsi: stop using display->ctx pointer >> >> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 96 ++++++++++++++++----------------- >> 1 file changed, 47 insertions(+), 49 deletions(-) >> > >