All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Brace <brace77070@gmail.com>
To: Fabian Frederick <fabf@skynet.be>, linux-kernel@vger.kernel.org
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>,
	iss_storagedev@hp.com, linux-scsi@vger.kernel.org,
	don.brace@pmcs.com, hch@infradead.org
Subject: Re: [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc
Date: Thu, 30 Oct 2014 10:21:05 -0500	[thread overview]
Message-ID: <54525761.8070800@gmail.com> (raw)
In-Reply-To: <1414595704-3119-1-git-send-email-fabf@skynet.be>

On 10/29/2014 10:15 AM, Fabian Frederick wrote:
> Fix -Wunused-but-set-variable warning
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
>   drivers/scsi/hpsa.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index cef5d49..34330e1 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -6619,11 +6619,11 @@ static void hpsa_free_cmd_pool(struct ctlr_info *h)
>
>   static void hpsa_irq_affinity_hints(struct ctlr_info *h)
>   {
> -	int i, cpu, rc;
> +	int i, cpu;
>
>   	cpu = cpumask_first(cpu_online_mask);
>   	for (i = 0; i < h->msix_vector; i++) {
> -		rc = irq_set_affinity_hint(h->intr[i], get_cpu_mask(cpu));
> +		irq_set_affinity_hint(h->intr[i], get_cpu_mask(cpu));
>   		cpu = cpumask_next(cpu, cpu_online_mask);
>   	}
>   }
>

I can add this patch to my current set of patches for 3.19 or ack this 
now, What would you prefer?

---
Don Brace
don.brace@pmcs.com

  parent reply	other threads:[~2014-10-30 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-29 15:15 [PATCH 1/1 linux-next] hpsa: remove set but unused variable rc Fabian Frederick
2014-10-30  5:55 ` Sudip Mukherjee
2014-10-30  6:28   ` Elliott, Robert (Server Storage)
2014-10-30  6:40     ` Sudip Mukherjee
2014-10-30 15:21 ` Don Brace [this message]
2014-10-30 15:27   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54525761.8070800@gmail.com \
    --to=brace77070@gmail.com \
    --cc=JBottomley@parallels.com \
    --cc=don.brace@pmcs.com \
    --cc=fabf@skynet.be \
    --cc=hch@infradead.org \
    --cc=iss_storagedev@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.