From: Eric Blake <eblake@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Benoit Canet <benoit@irqsave.net>,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] block: Add bdrv_get_node_name
Date: Thu, 30 Oct 2014 15:33:57 -0600 [thread overview]
Message-ID: <5452AEC5.10104@redhat.com> (raw)
In-Reply-To: <1414559044-14501-3-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 661 bytes --]
On 10/28/2014 11:04 PM, Fam Zheng wrote:
> This returns the node name of a BDS. Remove the TODO comment and expect
> the callers to be explicit.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> block.c | 6 +++++-
> include/block/block.h | 1 +
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
Can still return NULL because we don't have Jeff's patches for
auto-assigning a node name everywhere, right? But that doesn't matter
in the context of this patch, so:
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 539 bytes --]
next prev parent reply other threads:[~2014-10-31 15:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 5:04 [Qemu-devel] [PATCH 0/4] block: Allow query stats for drive-mirror target Fam Zheng
2014-10-29 5:04 ` [Qemu-devel] [PATCH 1/4] block: Add bdrv_next_node Fam Zheng
2014-10-29 8:49 ` Max Reitz
2014-10-30 21:32 ` Eric Blake
2014-10-29 5:04 ` [Qemu-devel] [PATCH 2/4] block: Add bdrv_get_node_name Fam Zheng
2014-10-29 8:51 ` Max Reitz
2014-10-30 21:33 ` Eric Blake [this message]
2014-10-29 5:04 ` [Qemu-devel] [PATCH 3/4] block: Include "node-name" if present in query-blockstats Fam Zheng
2014-10-29 8:57 ` Max Reitz
2014-10-30 21:36 ` Eric Blake
2014-10-29 5:04 ` [Qemu-devel] [PATCH 4/4] qmp: Add optional switch "query-nodes" " Fam Zheng
2014-10-29 9:11 ` Max Reitz
2014-10-31 3:20 ` Fam Zheng
2014-11-04 8:49 ` Max Reitz
2014-10-30 21:47 ` Eric Blake
2014-10-31 3:14 ` Fam Zheng
2014-10-30 21:48 ` [Qemu-devel] [PATCH 0/4] block: Allow query stats for drive-mirror target Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5452AEC5.10104@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=benoit@irqsave.net \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.