From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Damien Zammit <damien.zammit@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] usb-audio: Add mixer control for Digidesign Mbox 1 clock source
Date: Fri, 31 Oct 2014 12:29:22 +0900 [thread overview]
Message-ID: <54530212.7000804@sakamocchi.jp> (raw)
In-Reply-To: <5452EC80.8060005@gmail.com>
Hi Damien,
On Oct 31 2014 10:57, Damien Zammit wrote:
> This patch provides a mixer control for selecting the clock source of
> the Digidesign Mbox 1 to either internal clock or S/PDIF external.
> Trial and error and bus snooping were the only way to get this
> information, but it works on the hardware.
This patch includes lines over 80 characters. Furthermore, these lines
include inappropriate white-space for indentation. How about indenting
with tab only and add more line-breaks between each function parameter?
$ ./scripts/checkpatch.pl /tmp/0001-mbox1-spdif.patch
WARNING: line over 80 characters
#134: FILE: sound/usb/mixer_quirks.c:641:
+ usb_rcvctrlpipe(mixer->chip->dev,
0), 0x81,
WARNING: line over 80 characters
#135: FILE: sound/usb/mixer_quirks.c:642:
+ USB_DIR_IN | USB_TYPE_CLASS |
USB_RECIP_INTERFACE,
WARNING: line over 80 characters
#140: FILE: sound/usb/mixer_quirks.c:647:
+ usb_rcvctrlpipe(mixer->chip->dev,
0), 0x81,
WARNING: line over 80 characters
#141: FILE: sound/usb/mixer_quirks.c:648:
+ USB_DIR_IN | USB_TYPE_CLASS |
USB_RECIP_ENDPOINT,
WARNING: line over 80 characters
#159: FILE: sound/usb/mixer_quirks.c:666:
+ usb_rcvctrlpipe(mixer->chip->dev,
0), 0x81,
WARNING: line over 80 characters
#160: FILE: sound/usb/mixer_quirks.c:667:
+ USB_DIR_IN | USB_TYPE_CLASS |
USB_RECIP_ENDPOINT,
WARNING: line over 80 characters
#165: FILE: sound/usb/mixer_quirks.c:672:
+ usb_rcvctrlpipe(mixer->chip->dev,
0), 0x81,
WARNING: line over 80 characters
#166: FILE: sound/usb/mixer_quirks.c:673:
+ USB_DIR_IN | USB_TYPE_CLASS |
USB_RECIP_ENDPOINT,
total: 0 errors, 8 warnings, 226 lines checked
/tmp/0001-mbox1-spdif.patch has style problems, please review.
If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Regards
Takashi Sakamoto
o-takashi@sakamocchi.jp
next prev parent reply other threads:[~2014-10-31 3:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 1:57 [PATCH] usb-audio: Add mixer control for Digidesign Mbox 1 clock source Damien Zammit
2014-10-31 3:29 ` Takashi Sakamoto [this message]
2014-10-31 4:02 ` Damien Zammit
2014-10-31 4:28 ` Takashi Sakamoto
2014-10-31 4:45 ` Damien Zammit
2014-10-31 5:13 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54530212.7000804@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=damien.zammit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.