From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] blackfin: rename blackfin i2c driver to adi
Date: Fri, 31 Oct 2014 09:06:48 +0100 [thread overview]
Message-ID: <54534318.7050902@denx.de> (raw)
In-Reply-To: <CAHG8p1A=JrB1upHkGK9PSxaj7j7eS6hiS7iOvi8wjYA2r-6_cA@mail.gmail.com>
Hello Scott Jiang,
Am 31.10.2014 08:12, schrieb Scott Jiang:
> Hi Heiko,
>
>
>>> static int wait_for_completion(struct i2c_msg *msg)
>>> {
>>> - uint16_t int_stat;
>>> + u16 int_stat, ctl;
>>
>>
>> This change is not related to the subject of the patch,
>> please split this into seperate patches ...
>>
>>> ulong timebase = get_timer(0);
>>>
>>> do {
>>> - int_stat = twi->int_stat;
>>> + int_stat = readw(&twi->int_stat);
>>
>>
>> Here too... please fix globally.
>>
>
> This patch is to modify blackfin specific string or api to generic.
> So I use standard io api readl/writel here. I'm not sure what you
> mean.
The use of the generic i/o accessors would be a seperate patch...
subject something like "blackfin i2c: use generic io accessors"
and put the rename specific changes into
"blackfin: rename blackfin i2c driver to adi"
bye,
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
prev parent reply other threads:[~2014-10-31 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 6:08 [U-Boot] [PATCH] blackfin: rename blackfin i2c driver to adi Scott Jiang
2014-10-31 6:29 ` Heiko Schocher
2014-10-31 7:12 ` Scott Jiang
2014-10-31 8:06 ` Heiko Schocher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54534318.7050902@denx.de \
--to=hs@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.