From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools/hvmloader: link errno.h from xen internal Date: Fri, 31 Oct 2014 10:54:16 +0000 Message-ID: <54536A58.50307@citrix.com> References: <1414721915-11186-1-git-send-email-tiejun.chen@intel.com> <54535E97.2000105@citrix.com> <545377B40200007800043E2E@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <545377B40200007800043E2E@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Tiejun Chen , xen-devel@lists.xen.org, wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org On 31/10/14 10:51, Jan Beulich wrote: >>>> On 31.10.14 at 11:04, wrote: >> On 31/10/14 02:18, Tiejun Chen wrote: >>> We will use some error numbers in hvmloader so here just link >>> this head file from xen. >>> >>> Signed-off-by: Tiejun Chen >> We already use stdint, stdarg, stdarg and error (in xenbus.c) from the >> build environment. >> >> All of these are safe from an embedded point of view, which is >> essentially what we are doing with hvmloader. >> >> I highly suggest we just go with the environments error.h and be done >> with it. C99 is very nice to us in this way. > No, specifically not, as the values defined there may not correspond > with the ones Xen defines (POSIX doesn't mandate specific numbers). Good point, which reminds me. The Xen error numbers must form part of the public API, as they are already part of the public ABI. ~Andrew