From: Anand Jain <Anand.Jain@oracle.com>
To: Karel Zak <kzak@redhat.com>
Cc: linux-btrfs@vger.kernel.org, dsterba@suse.cz
Subject: Re: [PATCH 2/2 v4] btrfs-progs: optimize btrfs_scan_lblkid() for multiple calls
Date: Fri, 31 Oct 2014 19:04:58 +0800 [thread overview]
Message-ID: <54536CDA.4090901@oracle.com> (raw)
In-Reply-To: <20141031090830.GP10134@x2.net.home>
On 31/10/2014 17:08, Karel Zak wrote:
> On Fri, Oct 31, 2014 at 12:11:20PM +0800, Anand Jain wrote:
>> btrfs_scan_lblikd() is called by most the device related command functions.
>> And btrfs_scan_lblkid() is most expensive function and it becomes more expensive
>> as number of devices in the system increase. Further some threads call this
>
> wouldn't be possible to ask udev rather than scan all devices? I
> understand than in some cases it's necessary to have robust and
> independent solution, but for usual use-cases it would be less
> expensive to read the info from udev where we already keep track about
> all block devices and where we call libblkid.
>
> It would be possible to implement it as optional feature (#ifdev HAVE_LIBUDEV),
> the library API is very easy to use.
>
> (For example lsblk uses libblkid as fallback, the default is udev).
>
> Karel
>
>
I might be missing something, correct me if wrong. Is there any udev API
which gives me a list of devices which hold btrfs ? I just browsed
through there isn't any.
Anand
next prev parent reply other threads:[~2014-10-31 11:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 0:51 [PATCH 1/2] btrfs-progs: introduce btrfs_register_all_device() Anand Jain
2014-10-15 0:51 ` [PATCH 2/2] btrfs-progs: optimize btrfs_scan_lblkid() for multiple calls Anand Jain
2014-10-23 6:30 ` [PATCH 2/2 v2] " Anand Jain
2014-10-30 14:18 ` David Sterba
2014-10-31 1:38 ` Anand Jain
2014-10-31 3:19 ` [PATCH 2/2 v3] " Anand Jain
2014-10-30 14:33 ` [PATCH 1/2] btrfs-progs: introduce btrfs_register_all_device() David Sterba
2014-10-31 2:28 ` Anand Jain
2014-10-31 4:11 ` [PATCH 1/2 v4] " Anand Jain
2014-10-31 4:11 ` [PATCH 2/2 v4] btrfs-progs: optimize btrfs_scan_lblkid() for multiple calls Anand Jain
2014-10-31 9:08 ` Karel Zak
2014-10-31 11:04 ` Anand Jain [this message]
2014-11-11 11:47 ` Karel Zak
2014-11-14 16:51 ` David Sterba
2014-11-28 9:33 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54536CDA.4090901@oracle.com \
--to=anand.jain@oracle.com \
--cc=dsterba@suse.cz \
--cc=kzak@redhat.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.