From: Loic Poulain <loic.poulain@intel.com>
To: marcel@holtmann.org, gustavo@padovan.org,
linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: HCI H5 peer reset detection
Date: Fri, 31 Oct 2014 16:08:05 +0100 [thread overview]
Message-ID: <5453A5D5.3060801@intel.com> (raw)
In-Reply-To: <20141031083908.GB18888@t440s.P-661HNU-F1>
Hi Johan,
This is just the expected behavior as described int the specification:
UART Spec says:
If the UART synchronization is lost in the communication from Host to Host
Controller, then the Host Controller shall send a Hardware Error Event
to tell
the Host about the synchronization error. The Host Controller will then
expect to
receive an HCI_Reset command from the Host in order to perform a reset. The
Host Controller will also use the HCI_Reset command in the byte stream from
Host to Host Controller to re-synchronize.
H5 part says:
If a SYNC message is received while in the Active State, it is assumed
that the
peer device has reset. The local device should therefore perform a full
reset of
the upper stack, and start Link Establishment again at the Uninitialized
State.
So, hardware error seems the best way to warn host stack about the H5
controller
reset.
Regarding the "upper stack", I know that Bluedroid restarts on hardware
error, but
I ignore the Bluez behavior.
Regards,
Loic
On 31/10/2014 09:39, Johan Hedberg wrote:
> Hi Loic,
>
> On Wed, Oct 08, 2014, Loic Poulain wrote:
>> This patch resets the HCI H5 driver data/state to unitialized and
>> reports an HCI hardware error event to notify the upper stack that
>> HCI synchronization has been lost. H5 will be re-synchronized and
>> upper stack should generate an HCI Reset command.
> I couldn't find anywhere where we'd currently do this "upper stack"
> behavior that you describe (there . Did you have some follow-up patches to
> implement that?
>
> Johan
--
Intel Open Source Technology Center
http://oss.intel.com/
next prev parent reply other threads:[~2014-10-31 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-08 14:54 [PATCH] Bluetooth: HCI H5 peer reset detection Loic Poulain
2014-10-31 8:39 ` Johan Hedberg
2014-10-31 15:08 ` Loic Poulain [this message]
2014-10-31 16:50 ` Marcel Holtmann
2014-10-31 17:58 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5453A5D5.3060801@intel.com \
--to=loic.poulain@intel.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.