From: Lars-Peter Clausen <lars@metafoo.de>
To: Ezequiel Garcia <ezequiel.garcia@imgtec.com>,
linux-iio@vger.kernel.org, jic23@kernel.org,
Naidu.Tellapati@imgtec.com, james.hartley@imgtec.com,
abrestic@chromium.org
Cc: Phani Movva <Phani.Movva@imgtec.com>
Subject: Re: [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver
Date: Fri, 31 Oct 2014 20:44:23 +0100 [thread overview]
Message-ID: <5453E697.7050107@metafoo.de> (raw)
In-Reply-To: <5453C494.4030906@metafoo.de>
On 10/31/2014 06:19 PM, Lars-Peter Clausen wrote:
> On 10/29/2014 09:45 PM, Ezequiel Garcia wrote:
>> From: Phani Movva <Phani.Movva@imgtec.com>
>>
>> This commit adds support for Cosmic Circuits 10001 10-bit ADC device.
>>
>> Signed-off-by: Phani Movva <Phani.Movva@imgtec.com>
>> Signed-off-by: Naidu Tellapati <Naidu.Tellapati@imgtec.com>
>> [Ezequiel: code style cleaning]
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@imgtec.com>
>
> Looks very good. Just a few very minor issues.
One thing I forgot to mention. We use indio_dev for the name of the struct
iio_dev variable. Please use this in this driver as well, makes it easier to
follow and review the code.
- Lars
next prev parent reply other threads:[~2014-10-31 19:44 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 20:45 [PATCH 0/2] iio: Add Cosmic Circuits ADC support Ezequiel Garcia
2014-10-29 20:45 ` [PATCH 1/2] iio: adc: Cosmic Circuits 10001 ADC driver Ezequiel Garcia
2014-10-31 17:19 ` Lars-Peter Clausen
2014-10-31 19:44 ` Lars-Peter Clausen [this message]
2014-11-04 23:29 ` Ezequiel Garcia
2014-11-05 13:35 ` Jonathan Cameron
2014-10-31 20:26 ` Peter Meerwald
2014-11-04 23:47 ` Ezequiel Garcia
2014-11-01 23:11 ` Hartmut Knaack
2014-11-04 23:41 ` Ezequiel Garcia
2014-11-05 13:41 ` Jonathan Cameron
2014-11-05 13:36 ` Jonathan Cameron
2014-10-29 20:45 ` [PATCH 2/2] DT: iio: adc: Add CC_10001 binding documentation Ezequiel Garcia
2014-11-05 13:40 ` Jonathan Cameron
2014-11-05 13:40 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5453E697.7050107@metafoo.de \
--to=lars@metafoo.de \
--cc=Naidu.Tellapati@imgtec.com \
--cc=Phani.Movva@imgtec.com \
--cc=abrestic@chromium.org \
--cc=ezequiel.garcia@imgtec.com \
--cc=james.hartley@imgtec.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.