From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Sat, 01 Nov 2014 09:45:46 +0100 Subject: [PATCH 1/2] regulator: Document binding for regulator suspend voltage In-Reply-To: <1414813978-32233-1-git-send-email-dianders@chromium.org> References: <1414813978-32233-1-git-send-email-dianders@chromium.org> Message-ID: <54549DBA.5020102@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > This patch builds upon (291d761 regulator: Document binding for > regulator suspend state for PM state) to allow setting the uV in > addition to the state at suspend time. > > Signed-off-by: Doug Anderson > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index aaad615..4e7ed76 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -28,6 +28,8 @@ Optional properties: > - regulator-state-[mem/disk] node has following common properties: > - regulator-on-in-suspend: regulator should be on in suspend state. > - regulator-off-in-suspend: regulator should be off in suspend state. > + - regulator-suspend-microvolt: regulator should be set to this voltage > + in suspend. The patch looks good to me: Reviewed-by: Javier Martinez Canillas On thing I wonder is if the binding should say that the suspend voltage is independent of the runtime one and it may be outside of the runtime range? Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage Date: Sat, 01 Nov 2014 09:45:46 +0100 Message-ID: <54549DBA.5020102@collabora.co.uk> References: <1414813978-32233-1-git-send-email-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1414813978-32233-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Doug Anderson , Mark Brown Cc: Heiko Stuebner , Chris Zhong , Andrew Bresticker , Chanwoo Choi , Kyungmin Park , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, carlos-FEoyFZUZMvJAfugRpC6u6w@public.gmane.org, rdunlap-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, jkosina-AlSwsSmVLrQ@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > This patch builds upon (291d761 regulator: Document binding for > regulator suspend state for PM state) to allow setting the uV in > addition to the state at suspend time. > > Signed-off-by: Doug Anderson > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index aaad615..4e7ed76 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -28,6 +28,8 @@ Optional properties: > - regulator-state-[mem/disk] node has following common properties: > - regulator-on-in-suspend: regulator should be on in suspend state. > - regulator-off-in-suspend: regulator should be off in suspend state. > + - regulator-suspend-microvolt: regulator should be set to this voltage > + in suspend. The patch looks good to me: Reviewed-by: Javier Martinez Canillas On thing I wonder is if the binding should say that the suspend voltage is independent of the runtime one and it may be outside of the runtime range? Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757764AbaKAIp5 (ORCPT ); Sat, 1 Nov 2014 04:45:57 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:35978 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751343AbaKAIpy (ORCPT ); Sat, 1 Nov 2014 04:45:54 -0400 Message-ID: <54549DBA.5020102@collabora.co.uk> Date: Sat, 01 Nov 2014 09:45:46 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Doug Anderson , Mark Brown CC: Heiko Stuebner , Chris Zhong , Andrew Bresticker , Chanwoo Choi , Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, carlos@github.map.fastly.net, rdunlap@infradead.org, jkosina@suse.cz, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] regulator: Document binding for regulator suspend voltage References: <1414813978-32233-1-git-send-email-dianders@chromium.org> In-Reply-To: <1414813978-32233-1-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > This patch builds upon (291d761 regulator: Document binding for > regulator suspend state for PM state) to allow setting the uV in > addition to the state at suspend time. > > Signed-off-by: Doug Anderson > --- > Documentation/devicetree/bindings/regulator/regulator.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt > index aaad615..4e7ed76 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.txt > +++ b/Documentation/devicetree/bindings/regulator/regulator.txt > @@ -28,6 +28,8 @@ Optional properties: > - regulator-state-[mem/disk] node has following common properties: > - regulator-on-in-suspend: regulator should be on in suspend state. > - regulator-off-in-suspend: regulator should be off in suspend state. > + - regulator-suspend-microvolt: regulator should be set to this voltage > + in suspend. The patch looks good to me: Reviewed-by: Javier Martinez Canillas On thing I wonder is if the binding should say that the suspend voltage is independent of the runtime one and it may be outside of the runtime range? Best regards, Javier