From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier.martinez@collabora.co.uk (Javier Martinez Canillas) Date: Sat, 01 Nov 2014 09:49:42 +0100 Subject: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state In-Reply-To: <1414813978-32233-2-git-send-email-dianders@chromium.org> References: <1414813978-32233-1-git-send-email-dianders@chromium.org> <1414813978-32233-2-git-send-email-dianders@chromium.org> Message-ID: <54549EA6.5060007@collabora.co.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > Leverage all the work that was done in (40e20d6 regulator: of: Add > support for parsing regulator_state for suspend state) and throw in > the ability to set suspend microvolts from the device tree. > > Signed-off-by: Doug Anderson > --- > drivers/regulator/of_regulator.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c > index f0d19fc..7fe93c5 100644 > --- a/drivers/regulator/of_regulator.c > +++ b/drivers/regulator/of_regulator.c > @@ -107,6 +107,10 @@ static void of_get_regulation_constraints(struct device_node *np, > "regulator-off-in-suspend")) > suspend_state->disabled = true; > > + if (!of_property_read_u32(suspend_np, > + "regulator-suspend-microvolt", &pval)) > + suspend_state->uV = pval; > + > of_node_put(suspend_np); > suspend_state = NULL; > suspend_np = NULL; > Looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758555AbaKAItv (ORCPT ); Sat, 1 Nov 2014 04:49:51 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:35995 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751388AbaKAItt (ORCPT ); Sat, 1 Nov 2014 04:49:49 -0400 Message-ID: <54549EA6.5060007@collabora.co.uk> Date: Sat, 01 Nov 2014 09:49:42 +0100 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.0 MIME-Version: 1.0 To: Doug Anderson , Mark Brown CC: Heiko Stuebner , Chris Zhong , Andrew Bresticker , Chanwoo Choi , Kyungmin Park , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] regulator: of: Add support for parsing microvolts for suspend state References: <1414813978-32233-1-git-send-email-dianders@chromium.org> <1414813978-32233-2-git-send-email-dianders@chromium.org> In-Reply-To: <1414813978-32233-2-git-send-email-dianders@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Doug, On 11/01/2014 04:52 AM, Doug Anderson wrote: > Leverage all the work that was done in (40e20d6 regulator: of: Add > support for parsing regulator_state for suspend state) and throw in > the ability to set suspend microvolts from the device tree. > > Signed-off-by: Doug Anderson > --- > drivers/regulator/of_regulator.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c > index f0d19fc..7fe93c5 100644 > --- a/drivers/regulator/of_regulator.c > +++ b/drivers/regulator/of_regulator.c > @@ -107,6 +107,10 @@ static void of_get_regulation_constraints(struct device_node *np, > "regulator-off-in-suspend")) > suspend_state->disabled = true; > > + if (!of_property_read_u32(suspend_np, > + "regulator-suspend-microvolt", &pval)) > + suspend_state->uV = pval; > + > of_node_put(suspend_np); > suspend_state = NULL; > suspend_np = NULL; > Looks good to me. Reviewed-by: Javier Martinez Canillas Best regards, Javier