From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1XknIl-0007Io-PJ for mharc-qemu-trivial@gnu.org; Sun, 02 Nov 2014 01:02:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XknIf-0007If-Ph for qemu-trivial@nongnu.org; Sun, 02 Nov 2014 01:02:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XknIa-0006o3-S5 for qemu-trivial@nongnu.org; Sun, 02 Nov 2014 01:02:01 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:34789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XknIa-0006dp-7W; Sun, 02 Nov 2014 01:01:56 -0400 Received: from 172.24.2.119 (EHLO szxeml409-hub.china.huawei.com) ([172.24.2.119]) by szxrg02-dlp.huawei.com (MOS 4.3.7-GA FastPath queued) with ESMTP id CBS73759; Sun, 02 Nov 2014 13:01:44 +0800 (CST) Received: from [127.0.0.1] (10.177.19.102) by szxeml409-hub.china.huawei.com (10.82.67.136) with Microsoft SMTP Server id 14.3.158.1; Sun, 2 Nov 2014 13:01:35 +0800 Message-ID: <5455BA9F.1040807@huawei.com> Date: Sun, 2 Nov 2014 13:01:19 +0800 From: Gonglei User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 MIME-Version: 1.0 To: Michael Tokarev References: <1414724010-1756-1-git-send-email-arei.gonglei@huawei.com> <5455B961.7080303@msgid.tls.msk.ru> In-Reply-To: <5455B961.7080303@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.19.102] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 119.145.14.65 Cc: "qemu-trivial@nongnu.org" , "qemu-devel@nongnu.org" , "stefanha@redhat.com" , "Huangpeng \(Peter\)" Subject: Re: [Qemu-trivial] [PATCH] tap_int.h: remove repeating macroinstruction X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Nov 2014 05:02:06 -0000 On 2014/11/2 12:56, Michael Tokarev wrote: > 31.10.2014 05:53, arei.gonglei@huawei.com wrote: >> From: Gonglei >> >> DEFAULT_NETWORK_SCRIPT and DEFAULT_NETWORK_DOWN_SCRIPT >> have been defined in net/net.h included in >> tap.c, which is the only C file that using those two macro. >> Let's remove the repeating macroinstruction. > > Applied (as I noted yesterday), but with slight rename in > $subject - the new subject reads: > > tap_int.h: remove repeating NETWORK_SCRIPT defines > > Is that okay with you? > Ack. Thanks. Best regards, -Gonglei From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XknIp-0007MD-Ed for qemu-devel@nongnu.org; Sun, 02 Nov 2014 01:02:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XknIk-0006qS-Jk for qemu-devel@nongnu.org; Sun, 02 Nov 2014 01:02:11 -0400 Message-ID: <5455BA9F.1040807@huawei.com> Date: Sun, 2 Nov 2014 13:01:19 +0800 From: Gonglei MIME-Version: 1.0 References: <1414724010-1756-1-git-send-email-arei.gonglei@huawei.com> <5455B961.7080303@msgid.tls.msk.ru> In-Reply-To: <5455B961.7080303@msgid.tls.msk.ru> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] tap_int.h: remove repeating macroinstruction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: "qemu-trivial@nongnu.org" , "qemu-devel@nongnu.org" , "stefanha@redhat.com" , "Huangpeng (Peter)" On 2014/11/2 12:56, Michael Tokarev wrote: > 31.10.2014 05:53, arei.gonglei@huawei.com wrote: >> From: Gonglei >> >> DEFAULT_NETWORK_SCRIPT and DEFAULT_NETWORK_DOWN_SCRIPT >> have been defined in net/net.h included in >> tap.c, which is the only C file that using those two macro. >> Let's remove the repeating macroinstruction. > > Applied (as I noted yesterday), but with slight rename in > $subject - the new subject reads: > > tap_int.h: remove repeating NETWORK_SCRIPT defines > > Is that okay with you? > Ack. Thanks. Best regards, -Gonglei