From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Xknt1-0004GB-H0 for mharc-qemu-trivial@gnu.org; Sun, 02 Nov 2014 01:39:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xknsu-000479-IO for qemu-trivial@nongnu.org; Sun, 02 Nov 2014 01:39:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xknsp-0007v8-MD for qemu-trivial@nongnu.org; Sun, 02 Nov 2014 01:39:28 -0400 Received: from isrv.corpit.ru ([86.62.121.231]:38480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xknsf-0007to-PE; Sun, 02 Nov 2014 01:39:13 -0400 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id D7FAF40231; Sun, 2 Nov 2014 08:39:12 +0300 (MSK) Message-ID: <5455C380.7080506@msgid.tls.msk.ru> Date: Sun, 02 Nov 2014 08:39:12 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: arei.gonglei@huawei.com, qemu-devel@nongnu.org References: <1414906637-11048-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1414906637-11048-1-git-send-email-arei.gonglei@huawei.com> OpenPGP: id=804465C5 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com, stefanha@redhat.com Subject: Re: [Qemu-trivial] [PATCH v2] tap: fix possible fd leak in net_init_tap X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Nov 2014 05:39:33 -0000 02.11.2014 08:37, arei.gonglei@huawei.com wrote: > > In hotplugging scenario, taking those true branch, the file > handler do not be closed. Let's close them before return. This looks much better now, and is shorter too :) Applied to -trivial, thank you! /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39143) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Xknsk-00042k-Qz for qemu-devel@nongnu.org; Sun, 02 Nov 2014 01:39:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Xknsg-0007ts-0O for qemu-devel@nongnu.org; Sun, 02 Nov 2014 01:39:18 -0400 Message-ID: <5455C380.7080506@msgid.tls.msk.ru> Date: Sun, 02 Nov 2014 08:39:12 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <1414906637-11048-1-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1414906637-11048-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] tap: fix possible fd leak in net_init_tap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, peter.huangpeng@huawei.com, stefanha@redhat.com 02.11.2014 08:37, arei.gonglei@huawei.com wrote: > > In hotplugging scenario, taking those true branch, the file > handler do not be closed. Let's close them before return. This looks much better now, and is shorter too :) Applied to -trivial, thank you! /mjt