All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: John Snow <jsnow@redhat.com>, Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] the need for if=none for -drive?
Date: Sun, 02 Nov 2014 10:21:13 +0300	[thread overview]
Message-ID: <5455DB69.3080308@msgid.tls.msk.ru> (raw)

All "modern" 2-way drive/device specifications need to explicitly
specify if=none for the drive for it to not be used in the default
ide bus implicitly.

But how about using some if=unspecified implicitly for all devices
which don't specify if=, pick any devices from that list which are
referenced from -device, and only add those which left (plus the
ones with explicit if=ide) to the default ide bus?

The change should be strighforward, the only (maybe significant)
prob I see is a need to reorder -device/-drive initialization in
vl.c.  We might pick them up in drive_check_orphaned() too.  Or,
we can walk over -devices when adding -drives with if={unspec,explicit}.

(this is a sort of a followup to 6b9e03a4e759876, "qtest/bios-tables:
Correct Q35 command line", but ofcourse it's a topic by its own).

Thanks,

/mjt

             reply	other threads:[~2014-11-02  7:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-02  7:21 Michael Tokarev [this message]
2014-11-03 19:15 ` [Qemu-devel] the need for if=none for -drive? John Snow
2014-12-17 11:52   ` Markus Armbruster
2015-01-08 13:47     ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5455DB69.3080308@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.