All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthias Klein <matthias.klein@linux.com>
To: Lars Melin <larsm17@gmail.com>,
	johan@kernel.org, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: option: Add ID for Peiker LTE NAD
Date: Sun, 02 Nov 2014 16:31:09 +0100	[thread overview]
Message-ID: <54564E3D.60806@linux.com> (raw)
In-Reply-To: <5455A676.2080305@gmail.com>


Am 02.11.2014 um 04:35 schrieb Lars Melin:
> On 2014-11-01 23:01, Matthias Klein wrote:
>> Add ID of the Peiker LTE NAD for legacy serial interface
>>
>> Signed-off-by: Matthias Klein <matthias.klein@linux.com>
>> ---
>>   drivers/usb/serial/option.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c
>> index d1a3f60..d7f1042 100644
>> --- a/drivers/usb/serial/option.c
>> +++ b/drivers/usb/serial/option.c
>> @@ -1091,6 +1091,7 @@ static const struct usb_device_id option_ids[] = {
>>       { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE 
>> MF330 */
>>       { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */
>>       { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */
>> +    { USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9025)}, /* Peiker LTE NAD */
>>       { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },
>>       { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },
>>       { USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),
> 05c6:9025 already has its net interface (#4) supported by the qmi_wwan 
> driver so your patch is wrong.
> There is also an ADB interface which I don't think should be driven by 
> option.
>
>
The ID is right, and it can be used with the option driver or qmi_wwan.
Ignore my patch, I will move to qmi_wwan in the future ...


  reply	other threads:[~2014-11-02 15:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01 16:01 [PATCH] usb: option: Add ID for Peiker LTE NAD Matthias Klein
2014-11-02  3:35 ` Lars Melin
2014-11-02 15:31   ` Matthias Klein [this message]
2014-11-04 12:40     ` Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54564E3D.60806@linux.com \
    --to=matthias.klein@linux.com \
    --cc=johan@kernel.org \
    --cc=larsm17@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.