From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39030)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <haifeng.lin@huawei.com>) id 1Xl6SH-0007Qd-Or
	for qemu-devel@nongnu.org; Sun, 02 Nov 2014 20:29:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <haifeng.lin@huawei.com>) id 1Xl6SB-00011A-K0
	for qemu-devel@nongnu.org; Sun, 02 Nov 2014 20:29:13 -0500
Received: from szxga01-in.huawei.com ([119.145.14.64]:54520)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <haifeng.lin@huawei.com>) id 1Xl6SB-00010L-2z
	for qemu-devel@nongnu.org; Sun, 02 Nov 2014 20:29:07 -0500
Message-ID: <5456DA3E.9030802@huawei.com>
Date: Mon, 3 Nov 2014 09:28:30 +0800
From: Linhaifeng <haifeng.lin@huawei.com>
MIME-Version: 1.0
References: <1414951296-8031-1-git-send-email-mst@redhat.com>
In-Reply-To: <1414951296-8031-1-git-send-email-mst@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] vhost-user: fix mmap offset calculation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org

good job!passed test bigger than 3.5G VM.

On 2014/11/3 2:01, Michael S. Tsirkin wrote:
> qemu_get_ram_block_host_ptr should get ram_addr_t,
> vhost-user passes in GPA.
> That's very wrong.
> 
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  hw/virtio/vhost-user.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
> index 4e88d9c..aefe0bb 100644
> --- a/hw/virtio/vhost-user.c
> +++ b/hw/virtio/vhost-user.c
> @@ -226,7 +226,7 @@ static int vhost_user_call(struct vhost_dev *dev, unsigned long int request,
>                  msg.memory.regions[fd_num].memory_size  = reg->memory_size;
>                  msg.memory.regions[fd_num].guest_phys_addr = reg->guest_phys_addr;
>                  msg.memory.regions[fd_num].mmap_offset = reg->userspace_addr -
> -                    (uintptr_t) qemu_get_ram_block_host_ptr(reg->guest_phys_addr);
> +                    (uintptr_t) qemu_get_ram_block_host_ptr(ram_addr);
>                  assert(fd_num < VHOST_MEMORY_MAX_NREGIONS);
>                  fds[fd_num++] = fd;
>              }
> 

-- 
Regards,
Haifeng