From: Mike Looijmans <mike.looijmans@topic.nl>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Add ltc3562 voltage regulator driver
Date: Mon, 3 Nov 2014 09:10:08 +0100 [thread overview]
Message-ID: <54573860.4060708@topic.nl> (raw)
In-Reply-To: <20141030165133.GB18557@sirena.org.uk>
On 10/30/2014 05:51 PM, Mark Brown wrote:
> On Thu, Oct 30, 2014 at 12:26:55PM +0100, Mike Looijmans wrote:
>> + np = of_node_get(i2c->dev.of_node);
>> + np_regulators = of_get_child_by_name(np, "regulators");
>
>> + np_child = of_get_child_by_name(np_regulators,
>> + ltc3562_regulators[i].name);
>> + if (np_child == NULL) {
>
> Use the core support for looking up constraints please - set
> regulators_node and so on.
I've been reworking the driver, but this is the only feedback comment I didn't
quite understand. What is it that I'm expected to do here? Probably just the
name of the method I'm supposed to call here would be enough.
The rest of your feedback I've processed and tested the results.
Mike.
Met vriendelijke groet / kind regards,
Mike Looijmans
System Expert
TOPIC Embedded Systems
Eindhovenseweg 32-C, NL-5683 KH Best
Postbus 440, NL-5680 AK Best
Telefoon: (+31) (0) 499 33 69 79
Telefax: (+31) (0) 499 33 69 70
E-mail: mike.looijmans@topic.nl
Website: www.topic.nl
Please consider the environment before printing this e-mail
Topic zoekt gedreven (embedded) software specialisten!
http://topic.nl/vacatures/topic-zoekt-software-engineers/
next prev parent reply other threads:[~2014-11-03 8:10 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 8:15 Add ltc3562 voltage regulator driver Mike Looijmans
2014-10-29 8:16 ` [PATCH] " Mike Looijmans
2014-10-29 12:30 ` Mark Brown
2014-10-30 6:47 ` Mike Looijmans
2014-10-30 10:15 ` Mark Brown
2014-10-30 10:29 ` Mike Looijmans
2014-10-30 10:53 ` Mike Looijmans
2014-10-30 10:58 ` Mark Brown
2014-10-30 11:31 ` Mike Looijmans
2014-10-30 12:04 ` Mark Brown
2014-10-30 11:26 ` [PATCH v2] " Mike Looijmans
2014-10-30 16:51 ` Mark Brown
2014-10-31 14:07 ` Mike Looijmans
2014-10-31 18:17 ` Mark Brown
2014-11-03 8:10 ` Mike Looijmans [this message]
2014-11-03 12:09 ` Mark Brown
2014-11-03 14:48 ` Mike Looijmans
2014-11-03 15:10 ` Mark Brown
2014-11-03 17:38 ` Mike Looijmans
2014-11-04 8:55 ` Mike Looijmans
2014-11-04 11:34 ` Mark Brown
2014-11-04 12:47 ` Mike Looijmans
2014-11-04 13:35 ` Mike Looijmans
2014-11-04 19:47 ` Mark Brown
2014-11-05 9:06 ` Krzysztof Kozlowski
2014-11-05 11:45 ` Mike Looijmans
2014-11-04 6:50 ` [PATCH v3] " Mike Looijmans
2014-11-04 20:26 ` Mark Brown
2014-11-05 11:41 ` Mike Looijmans
2014-11-05 13:34 ` Mark Brown
2014-10-29 10:03 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54573860.4060708@topic.nl \
--to=mike.looijmans@topic.nl \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.